From 9587fb9eaa26659e48a7bcaa82fd0c8180113a74 Mon Sep 17 00:00:00 2001 From: ashish sonam Date: Thu, 9 May 2024 13:08:36 +0530 Subject: [PATCH] condition fix --- .../service/AppStoreDeploymentDBService.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/appStore/installedApp/service/AppStoreDeploymentDBService.go b/pkg/appStore/installedApp/service/AppStoreDeploymentDBService.go index 0caf8fbf91..4218667f99 100644 --- a/pkg/appStore/installedApp/service/AppStoreDeploymentDBService.go +++ b/pkg/appStore/installedApp/service/AppStoreDeploymentDBService.go @@ -531,11 +531,12 @@ func (impl *AppStoreDeploymentDBServiceImpl) validateAndGetOverrideDeploymentApp isOCIRepo := appStoreAppVersion.AppStore.DockerArtifactStore != nil if isOCIRepo || getAppInstallationMode(installAppVersionRequest.AppOfferingMode) == globalUtil.SERVER_MODE_HYPERION { overrideDeploymentType = util.PIPELINE_DEPLOYMENT_TYPE_HELM - } - overrideDeploymentType, err = impl.deploymentTypeOverrideService.ValidateAndOverrideDeploymentAppType(overrideDeploymentType, isGitOpsConfigured, installAppVersionRequest.EnvironmentId) - if err != nil { - impl.logger.Errorw("validation error for the used deployment type", "appName", installAppVersionRequest.AppName, "err", err) - return overrideDeploymentType, err + } else { + overrideDeploymentType, err = impl.deploymentTypeOverrideService.ValidateAndOverrideDeploymentAppType(overrideDeploymentType, isGitOpsConfigured, installAppVersionRequest.EnvironmentId) + if err != nil { + impl.logger.Errorw("validation error for the used deployment type", "appName", installAppVersionRequest.AppName, "err", err) + return overrideDeploymentType, err + } } return overrideDeploymentType, nil }