Skip to content

feat: Restrict access on terminal for all non Super Admin Users #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented May 28, 2024

Description

introduced an env variable RESTRICT_TERMINAL_ACCESS_FOR_NON_SUPER_USER which if set true, only super admins will have access to terminal

Fixes #5179

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented May 28, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10190659 Triggered Generic High Entropy Secret b2ef0d6 wireNilChecker.env View secret
10190660 Triggered Generic Password b2ef0d6 tests/integrationTesting/devtron-secret.yaml View secret
10190661 Triggered Generic Password b2ef0d6 wireNilChecker.env View secret
10220829 Triggered Generic High Entropy Secret 8fbd2d7 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 8fbd2d7 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

kartik-579
kartik-579 previously approved these changes May 29, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit 2e664d6 into main Jun 10, 2024
7 of 8 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the terminal-restrict branch June 10, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Restrict access on terminal for all non Super Admin Users
4 participants