Skip to content

feat: notifier behind nats #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 7, 2024
Merged

feat: notifier behind nats #5185

merged 15 commits into from
Jun 7, 2024

Conversation

komalreddy3
Copy link
Contributor

@komalreddy3 komalreddy3 commented May 28, 2024 •
edited
Loading

Description

Fixes #5253

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@komalreddy3 komalreddy3 requested a review from gireesh-naidu May 28, 2024 08:17
@komalreddy3 komalreddy3 self-assigned this May 28, 2024
kripanshdevtron
kripanshdevtron previously approved these changes Jun 6, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@komalreddy3 komalreddy3 merged commit bb3790b into main Jun 7, 2024
8 checks passed
@komalreddy3 komalreddy3 deleted the feat-notifier-behind-nats branch June 7, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron kripanshdevtron left review comments

@gireesh-naidu gireesh-naidu Awaiting requested review from gireesh-naidu

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees

@komalreddy3 komalreddy3

Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Notifier behind nats
3 participants
@komalreddy3 @vikramdevtron @kripanshdevtron