Skip to content

feat: Added statefulset chart 5.1.0 #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 14, 2024
Merged

feat: Added statefulset chart 5.1.0 #5199

merged 19 commits into from
Jun 14, 2024

Conversation

akshatsinha007
Copy link
Contributor

fixes #5198

akshatsinha007 and others added 2 commits May 31, 2024 16:05
Copy link

gitguardian bot commented May 31, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret 4f117b5 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 4f117b5 charts/devtron/values.yaml View secret
2763127 Triggered Generic High Entropy Secret f3cd582 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret f3cd582 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@jatin-jangir-0220 jatin-jangir-0220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add migration script
with appropriate values

@pawan-mehta-dt pawan-mehta-dt changed the title feat: Updated statefulset-charts feat: Added statefulset chart 5.1.0 Jun 14, 2024
pawan-mehta-dt
pawan-mehta-dt previously approved these changes Jun 14, 2024
nishant-d
nishant-d previously approved these changes Jun 14, 2024
@pawan-mehta-dt pawan-mehta-dt dismissed stale reviews from nishant-d and themself via 3b01a67 June 14, 2024 13:24
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pawan-mehta-dt pawan-mehta-dt merged commit 7de572f into devtron-labs:main Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update Statefulset-Charts
4 participants