Skip to content

fix: revert changes from main #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

fix: revert changes from main #5206

merged 1 commit into from
May 30, 2024

Conversation

Kishan789dev
Copy link
Contributor

@Kishan789dev Kishan789dev commented May 30, 2024 •
edited by ShashwatDadhich
Loading

Description

Fixes #5209

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Kishan789dev Kishan789dev changed the title fix:Reverting the changes from main fix: #5209 May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: #5209 fix: Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: Unmerging from main fix: https://github.com/devtron-labs/devtron/issues May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: https://github.com/devtron-labs/devtron/issues fix: Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: Unmerging from main fix: Unmerging from main #5209 May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: Unmerging from main #5209 Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title Unmerging from main fix: Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title fix: Unmerging from main Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title Unmerging from main fix : Unmerging from main May 30, 2024
@Kishan789dev Kishan789dev changed the title fix : Unmerging from main fix : revert changes from main May 30, 2024
@ShashwatDadhich ShashwatDadhich changed the title fix : revert changes from main fix: revert changes from main May 30, 2024
@Kishan789dev Kishan789dev merged commit 0269dcd into main May 30, 2024
7 of 22 checks passed
@Kishan789dev Kishan789dev deleted the revert-5110-rback-related-bug branch May 30, 2024 08:36
@vikramdevtron vikramdevtron mentioned this pull request Jun 27, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kartik-579 kartik-579 kartik-579 approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmerging from main
3 participants
@Kishan789dev @vikramdevtron @kartik-579