feat: Flux App Listing #5250
Closed
feat: Flux App Listing #5250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajeevRanjan27
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
prakash100198
requested changes
Jun 5, 2024
prakash100198
requested changes
Jun 6, 2024
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
prakash100198
requested changes
Jun 10, 2024
|
|
||
| configs, err1 := impl.ConvertClusterBeanToClusterConfig(clusters) | ||
| if err1 != nil { | ||
| impl.logger.Errorw("error in getting all active clusters", "err", err1) |
There was a problem hiding this comment.
Is the error msg changed, I don't see that ?
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | 7d71b8c | charts/devtron/values.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | 7d71b8c | charts/devtron/devtron-bom.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 134e08c | scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 134e08c | scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
nishant-d
previously approved these changes
Jun 11, 2024
prakash100198
previously approved these changes
Jun 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5275
Checklist:
Does this PR introduce a user-facing change?