Skip to content

fix: Multiple choice option for namespace in Kubernetes resource permission #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

komalreddy3
Copy link
Contributor

Description

Fixes #3658

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@komalreddy3 komalreddy3 added the bug Something isn't working label Jun 12, 2024
@komalreddy3 komalreddy3 self-assigned this Jun 12, 2024
Shivam-nagar23
Shivam-nagar23 previously approved these changes Jun 12, 2024
@Shivam-nagar23
Copy link
Member

LGTM

vikramdevtron
vikramdevtron previously approved these changes Jun 12, 2024
@vikramdevtron vikramdevtron changed the title bug: multiple choice option for namespace in Kubernetes resource permission fix: multiple choice option for namespace in Kubernetes resource permission Jun 12, 2024
@vikramdevtron vikramdevtron changed the title fix: multiple choice option for namespace in Kubernetes resource permission fix: Multiple choice option for namespace in Kubernetes resource permission Jun 12, 2024
@komalreddy3 komalreddy3 changed the title fix: Multiple choice option for namespace in Kubernetes resource permission bug: Multiple choice option for namespace in Kubernetes resource permission Jun 13, 2024
@komalreddy3 komalreddy3 changed the title bug: Multiple choice option for namespace in Kubernetes resource permission fix: Multiple choice option for namespace in Kubernetes resource permission Jun 13, 2024
Copy link

gitguardian bot commented Jun 14, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
141558 Triggered Generic High Entropy Secret 3778678 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 3778678 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@komalreddy3 komalreddy3 dismissed stale reviews from Shivam-nagar23 and vikramdevtron via dc8a359 June 14, 2024 14:30
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@komalreddy3 komalreddy3 merged commit 1c7b816 into main Jun 14, 2024
7 checks passed
@komalreddy3 komalreddy3 deleted the bug-multiple-namespace-permission branch June 14, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Not able to see multiple choice option for namespace in Kubernetes resource permission.
4 participants