feat: Made ng labels env driven #6438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhibhaw
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
abhibhaw
changed the title
Shivam-nagar23
requested changes
Mar 7, 2025
|
LGTM |
Shivam-nagar23
previously approved these changes
Mar 7, 2025
vikramdevtron
dismissed
Shivam-nagar23’s stale review
The base branch was changed.
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
vikramdevtron
previously approved these changes
Mar 21, 2025
|
vikramdevtron
approved these changes
Mar 21, 2025
akshatsinha007
added a commit
that referenced
this pull request
Apr 7, 2025
* ci pipeline get change * ci pipeline get change * GetCiPipelineByIdWithDefaultTag change * deployment template get response * cd pipeline get response change * oss etn change * oss ent change * prom client in chart-sync * fix in yaml * APP_SYNC_SHUTDOWN_WAIT_DURATION env * APP_SYNC_SHUTDOWN_WAIT_DURATION env * vendor update in develop * fix: incorrect gitops metrics (#6444) * wip: fix gitops metrics * fix pull metrics * github create repo function * wip: metrics changed from defer function * fix metrics publish * self review changes * oss ent change * code cleaning * name suggestion util * added supoort for preserve mode in update repo api * fix in CreateGrafanaDataSource * fix in CreateGrafanaDataSource * feat: Made ng labels env driven (#6438) * feat: Adds karpenter ng to list of ng constants * feat: made nodelabels env driven * feat: Updates env get as per repo standards * prom client in chart-sync * fix in yaml * chore: resolve merge conflict * APP_SYNC_SHUTDOWN_WAIT_DURATION env * code cleaning --------- Co-authored-by: prakhar katiyar <prkhrkat@gmail.com> * updated timeout for git material save/update * fix: compile issue * updated protos version * added sql scripts * sql no update * wip: optimisation (#6473) * vendor update * feat: licensing changes (#6474) * modules handling * example * sql files * common lib update * release: Compatibility Modifications for Enterprise and OSS Chart (#6486) * added devtronEnterprise check conditions * added devtron-operator-cm in inception * added eneterprise flag in devtron-cm * updated dashboard cm * added random alpha for ent-job * added DEVTRON_VERSION_IDENTIFIER_IN_HELM_VALUES in devtro-cm * updated installer for enterprise * bom * fix: for grafana URL * fix: for grafana URL --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: prakhar katiyar <prkhrkat@gmail.com> Co-authored-by: Vikram Singh <vikram@devtron.ai> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: Abhibhaw Asthana <39991296+abhibhaw@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com>
pawan-mehta-dt
added a commit
that referenced
this pull request
Apr 23, 2025
* Updated release-notes files * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * misc: merged main in release-bot (#6500) * ci pipeline get change * ci pipeline get change * GetCiPipelineByIdWithDefaultTag change * deployment template get response * cd pipeline get response change * oss etn change * oss ent change * prom client in chart-sync * fix in yaml * APP_SYNC_SHUTDOWN_WAIT_DURATION env * APP_SYNC_SHUTDOWN_WAIT_DURATION env * vendor update in develop * fix: incorrect gitops metrics (#6444) * wip: fix gitops metrics * fix pull metrics * github create repo function * wip: metrics changed from defer function * fix metrics publish * self review changes * oss ent change * code cleaning * name suggestion util * added supoort for preserve mode in update repo api * fix in CreateGrafanaDataSource * fix in CreateGrafanaDataSource * feat: Made ng labels env driven (#6438) * feat: Adds karpenter ng to list of ng constants * feat: made nodelabels env driven * feat: Updates env get as per repo standards * prom client in chart-sync * fix in yaml * chore: resolve merge conflict * APP_SYNC_SHUTDOWN_WAIT_DURATION env * code cleaning --------- Co-authored-by: prakhar katiyar <prkhrkat@gmail.com> * updated timeout for git material save/update * fix: compile issue * updated protos version * added sql scripts * sql no update * wip: optimisation (#6473) * vendor update * feat: licensing changes (#6474) * modules handling * example * sql files * common lib update * release: Compatibility Modifications for Enterprise and OSS Chart (#6486) * added devtronEnterprise check conditions * added devtron-operator-cm in inception * added eneterprise flag in devtron-cm * updated dashboard cm * added random alpha for ent-job * added DEVTRON_VERSION_IDENTIFIER_IN_HELM_VALUES in devtro-cm * updated installer for enterprise * bom * fix: for grafana URL * fix: for grafana URL --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: prakhar katiyar <prkhrkat@gmail.com> Co-authored-by: Vikram Singh <vikram@devtron.ai> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: Abhibhaw Asthana <39991296+abhibhaw@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> * added liveness readiness * Update release.txt * Updated latest image of git-sensor in installer * Update devtron.yaml * Updated release notes * Updated release notes * added md=5 for postgresql * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * Updated release notes * feat: Postgres upgrade from 11 to 14 (#6525) * updated postgresql.yaml * updated the postgres image to postgre:14.9 and removed the postgres-misc migration * updated claim template name to devtron * updated claim template name to devtron * reverted the claim template name to data * changed targetport to actual portnumber instead of name * updated the check for POSTGRES_MIGRATED * POSTGRES_MIGRATED for devtron-custom-cm * POSTGRES_MIGRATED for devtron-custom-cm * synced from charts repo for airgapped argocd changes * moved nodeselectors,tolerations and imagepullsecrets below their description * Updated latest image of devtron in devtron * Updated latest image of kubewatch in devtron * Updated latest image of git-sensor in installer * updated gitsensor image * Updated devtron-bom.yaml * Updated latest image of lens in devtron * Updated latest image of ci-runner in devtron * Updated latest image of notifier in devtron * Updated latest image of image-scanner in devtron * updated image of notifier * updated image of notifier * Updated latest image of chart-sync in devtron * Updated latest image of hyperion in devtron * Updated latest image of kubelink in devtron * Updated release notes * Updated latest image of devtron in devtron * Updated latest image of kubewatch in devtron * Updated latest image of kubelink in devtron * Updated latest image of git-sensor in devtron * Updated latest image of lens in devtron * Updated latest image of ci-runner in devtron * Updated latest image of image-scanner in devtron * Updated latest image of chart-sync in devtron * Updated latest image of hyperion in devtron * Updated latest image of dashboard in devtron * Update devtron-bom.yaml * Update values.yaml * Updated release notes * Updated release notes * Updated release notes * modified postgresql.yaml * Update NOTES.txt * Updated the version in scripts * Update release.txt * Update version.txt * Update release-notes-v1.5.0.md * Update releasenotes.md * Update releasenotes.md Removed urmerged PR's * Update release-notes-v1.5.0.md * Update releasenotes.md * Update devtron-images.txt.source * Update releasenotes.md * Update releasenotes.md --------- Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: prakhar katiyar <prkhrkat@gmail.com> Co-authored-by: Vikram Singh <vikram@devtron.ai> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: Abhibhaw Asthana <39991296+abhibhaw@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: akshatsinha007 <akshat.sinha@devtron.ai> Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1979
Checklist:
Does this PR introduce a user-facing change?