Skip to content

feat: Enable selection of all CI pipelines at once when the Environment filter is applied in Notifications #6526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 23, 2025

Conversation

prkhrkat
Copy link
Contributor

@prkhrkat prkhrkat commented Apr 20, 2025

Description

Fixes #6458

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@prkhrkat prkhrkat changed the title Notifier refac feat: Enable selection of all CI pipelines at once when the Environment filter is applied in Notifications Apr 23, 2025
Copy link

The migration files have successfully passed the criteria!!

1 similar comment
Copy link

The migration files have successfully passed the criteria!!

Copy link

The migration files have successfully passed the criteria!!

Copy link

github-actions bot commented May 2, 2025

The migration files have successfully passed the criteria!!

Copy link

github-actions bot commented May 8, 2025

The migration files have successfully passed the criteria!!

Copy link

gitguardian bot commented May 23, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9257608 Triggered Base64 AWS keys 000bd42 scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 000bd42 scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 000bd42 scripts/devtron-reference-helm-charts/reference-chart_5-1-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@prkhrkat prkhrkat merged commit f7466f7 into develop May 23, 2025
6 checks passed
@prkhrkat prkhrkat deleted the notifier-refac branch May 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants