From 0e51243cd26bb93dbd794143baddcc318b4b603a Mon Sep 17 00:00:00 2001 From: prakhar katiyar Date: Tue, 20 May 2025 16:26:00 +0530 Subject: [PATCH 1/2] reverted telemetry connection error --- client/telemetry/TelemetryEventClient.go | 1 + 1 file changed, 1 insertion(+) diff --git a/client/telemetry/TelemetryEventClient.go b/client/telemetry/TelemetryEventClient.go index bfa4bf15c2..d9bc89067c 100644 --- a/client/telemetry/TelemetryEventClient.go +++ b/client/telemetry/TelemetryEventClient.go @@ -690,6 +690,7 @@ func (impl *TelemetryEventClientImpl) checkForOptOut(ctx context.Context, UCID s if err != nil { // this should be non-blocking call and should not fail the request for ucid getting impl.logger.Errorw("check opt-out list failed, rest api error", "ucid", UCID, "err", err) + return false, err } flag := response["result"].(bool) return flag, nil From 25b7912a0a87e9b03e4ece90d04b4616741ac972 Mon Sep 17 00:00:00 2001 From: prakhar katiyar Date: Tue, 20 May 2025 16:34:10 +0530 Subject: [PATCH 2/2] reverted telemetry connection error --- client/telemetry/TelemetryEventClient.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/client/telemetry/TelemetryEventClient.go b/client/telemetry/TelemetryEventClient.go index d9bc89067c..df44eb6130 100644 --- a/client/telemetry/TelemetryEventClient.go +++ b/client/telemetry/TelemetryEventClient.go @@ -20,6 +20,7 @@ import ( "context" "encoding/base64" "encoding/json" + "errors" "fmt" cloudProviderIdentifier "github.com/devtron-labs/common-lib/cloud-provider-identifier" posthogTelemetry "github.com/devtron-labs/common-lib/telemetry" @@ -692,7 +693,11 @@ func (impl *TelemetryEventClientImpl) checkForOptOut(ctx context.Context, UCID s impl.logger.Errorw("check opt-out list failed, rest api error", "ucid", UCID, "err", err) return false, err } - flag := response["result"].(bool) + flag, ok := response["result"].(bool) + if !ok { + impl.logger.Errorw("check opt-out list failed, type assertion error", "ucid", UCID) + return false, errors.New("type assertion error") + } return flag, nil }