feat: wf logs #6606
Merged
feat: wf logs #6606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-d
requested review from
vikramdevtron,
prakarsh-dt and
vivek-devtron
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new boolean parameter, followLogs, to the log fetching functions across several modules so that log streaming can be optionally followed. Key changes include updating function signatures in the CiLogService, both deployment and build HandlerService implementations, and modifying REST handlers to parse and pass the followLogs parameter.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/pipeline/CiLogService.go | Updated the FetchRunningWorkflowLogs function to accept and forward the followLogs parameter. |
| pkg/deployment/trigger/devtronApps/prePostWfAndLogsCode.go | Modified GetRunningWorkflowLogs and its helper to include the new followLogs parameter. |
| pkg/deployment/trigger/devtronApps/HandlerService.go | Updated the interface and implementation signatures to incorporate followLogs. |
| pkg/build/trigger/HandlerService.go | Added the followLogs parameter to log retrieval functions and updated corresponding internal calls. |
| api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go | Parsed the followLogs query parameter and passed it to the service call. |
| api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go | Similarly parsed and passed the followLogs parameter in GetBuildLogs. |
Comments suppressed due to low confidence (1)
pkg/build/trigger/HandlerService.go:1688
- Ensure that the addition of the followLogs parameter maintains backward compatibility with existing clients or that the change is adequately communicated in release notes.
func (impl *HandlerServiceImpl) GetRunningWorkflowLogs(workflowId int, followLogs bool) (*bufio.Reader, func() error, error) {
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
vikramdevtron
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2286
Checklist:
Does this PR introduce a user-facing change?