Skip to content

Commit c50f3c2

Browse files
author
David Hasani
committed
include build system in message
1 parent 99c19c6 commit c50f3c2

File tree

2 files changed

+25
-12
lines changed

2 files changed

+25
-12
lines changed

packages/core/src/amazonqGumby/chat/controller/controller.ts

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -325,9 +325,7 @@ export class GumbyController {
325325
const pathToProject: string = message.formSelectedValues['GumbyTransformProjectForm']
326326
const toJDKVersion: JDKVersion = message.formSelectedValues['GumbyTransformJdkToForm']
327327
const fromJDKVersion: JDKVersion = message.formSelectedValues['GumbyTransformJdkFromForm']
328-
329328
const projectName = path.basename(pathToProject)
330-
this.messenger.sendProjectSelectionMessage(projectName, fromJDKVersion, toJDKVersion, message.tabID)
331329

332330
if (fromJDKVersion === JDKVersion.UNSUPPORTED) {
333331
this.messenger.sendUnrecoverableErrorResponse('unsupported-source-jdk-version', message.tabID)
@@ -338,24 +336,37 @@ export class GumbyController {
338336

339337
// at this point, buildSystems is either [Maven], [Gradle], or [Maven, Gradle]
340338
const buildSystems = await checkBuildSystem(pathToProject)
341-
let selectedProjectBuildSystem = undefined
342-
if (buildSystems.length === 2) {
343-
// TO-DO: revert to 1
344-
selectedProjectBuildSystem = buildSystems[0]
339+
let selectedBuildSystem = undefined
340+
if (buildSystems.length === 1) {
341+
selectedBuildSystem = buildSystems[0]
345342
} else {
346343
// multiple build systems present, so ask user to pick one
347344
await this.messenger.sendBuildSystemPrompt(message.tabID)
348345
return
349346
}
350-
getLogger().info(`Selected project uses build system: ${selectedProjectBuildSystem}`)
351-
transformByQState.setBuildSystem(selectedProjectBuildSystem)
347+
getLogger().info(`Selected project uses build system: ${selectedBuildSystem}`)
348+
transformByQState.setBuildSystem(selectedBuildSystem)
349+
this.messenger.sendProjectSelectionMessage(
350+
projectName,
351+
fromJDKVersion,
352+
toJDKVersion,
353+
selectedBuildSystem,
354+
message.tabID
355+
)
352356
await this.validateBuildWithPromptOnError(message)
353357
}
354358

355359
private async handleBuildSystemForm(message: any) {
356-
const buildSystem: BuildSystem = message.formSelectedValues['GumbyTransformBuildSystemForm']
357-
getLogger().info(`Selected project uses Maven and Gradle; user selected build system: ${buildSystem}`)
358-
transformByQState.setBuildSystem(buildSystem)
360+
const selectedBuildSystem: BuildSystem = message.formSelectedValues['GumbyTransformBuildSystemForm']
361+
getLogger().info(`Selected project uses Maven and Gradle; user selected build system: ${selectedBuildSystem}`)
362+
transformByQState.setBuildSystem(selectedBuildSystem)
363+
this.messenger.sendProjectSelectionMessage(
364+
transformByQState.getProjectName(),
365+
transformByQState.getSourceJDKVersion()!,
366+
transformByQState.getTargetJDKVersion(),
367+
selectedBuildSystem,
368+
message.tabID
369+
)
359370
// this message obj is from the build system form, not the project selection form,
360371
// which is fine since validateBuildWithPromptOnError just needs the tab ID here
361372
await this.validateBuildWithPromptOnError(message)

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export class Messenger {
152152
},
153153
'TransformBuildSystemForm',
154154
tabID,
155-
false
155+
true
156156
)
157157
)
158158
}
@@ -466,6 +466,7 @@ export class Messenger {
466466
projectName: string,
467467
fromJDKVersion: JDKVersion,
468468
toJDKVersion: JDKVersion,
469+
buildSystem: BuildSystem,
469470
tabID: any
470471
) {
471472
const message = `### Transformation details
@@ -475,6 +476,7 @@ export class Messenger {
475476
| **Project** | ${projectName} |
476477
| **Source JDK version** | ${fromJDKVersion} |
477478
| **Target JDK version** | ${toJDKVersion} |
479+
| **Build system** | ${buildSystem} |
478480
`
479481

480482
this.dispatcher.sendChatMessage(new ChatMessage({ message, messageType: 'prompt' }, tabID))

0 commit comments

Comments
 (0)