-
Notifications
You must be signed in to change notification settings - Fork 17
Feature/add inline encryption #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for PR and I will check on weekend! :) |
Any update here? |
Nice feature, waiting for it to be merged :) |
I was tired of waiting for the merge of this new feature and I tried it in local. Unfortunately, in my machine with archlinux and lxde it does not work properly. When encrypting a single variable, it append a "\c" character at the end of the password that produces a wrong result. When you decrypt, this character appears. I am not a developer and I am not able to correct the code, sorry. Of course, it could be possible that I did something wrong. |
I'll try to fix that. I'm on macOs and haven't noticed that, but I'll try to make it work for all platforms. |
@dbseoane can you please try again? |
@dhoeric this would be awesome :) |
This PR is for supporting inline encryption supported from Ansible 2.3
I tried to not refactor too much, but that would produce some duplications and nasty code so, a bit more of refactoring. I might have missed something, so review is very welcomed.