Skip to content

Feature/add inline encryption #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vvucetic
Copy link

This PR is for supporting inline encryption supported from Ansible 2.3
I tried to not refactor too much, but that would produce some duplications and nasty code so, a bit more of refactoring. I might have missed something, so review is very welcomed.

@dhoeric dhoeric self-requested a review July 17, 2018 06:59
@dhoeric
Copy link
Owner

dhoeric commented Jul 17, 2018

Thanks for PR and I will check on weekend! :)

@tgeci
Copy link

tgeci commented Aug 29, 2018

Any update here?

@Matvey-Kuk
Copy link

Nice feature, waiting for it to be merged :)

@dbseoane
Copy link

I was tired of waiting for the merge of this new feature and I tried it in local. Unfortunately, in my machine with archlinux and lxde it does not work properly. When encrypting a single variable, it append a "\c" character at the end of the password that produces a wrong result. When you decrypt, this character appears. I am not a developer and I am not able to correct the code, sorry. Of course, it could be possible that I did something wrong.

@vvucetic
Copy link
Author

I was tired of waiting for the merge of this new feature and I tried it in local. Unfortunately, in my machine with archlinux and lxde it does not work properly. When encrypting a single variable, it append a "\c" character at the end of the password that produces a wrong result. When you decrypt, this character appears. I am not a developer and I am not able to correct the code, sorry. Of course, it could be possible that I did something wrong.

I'll try to fix that. I'm on macOs and haven't noticed that, but I'll try to make it work for all platforms.

@vvucetic
Copy link
Author

@dbseoane can you please try again?

@dbseoane
Copy link

@dbseoane can you please try again?

Wonderful @vvucetic. I just tried it and it works perfectly.
In fact, it works better than the atom plugin ;).
Thank you very much.

@roidelapluie
Copy link

@dhoeric this would be awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants