This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Fixes for issues in payload, undefined intents and telephony#258
Open
aybhalala wants to merge 2 commits intodialogflow:masterfrom
Open
Fixes for issues in payload, undefined intents and telephony#258aybhalala wants to merge 2 commits intodialogflow:masterfrom
aybhalala wants to merge 2 commits intodialogflow:masterfrom
Conversation
…ogflow. The dialogflow's payload-response requires a platform string and it cannot be undefined, so considering the convention used in rich-response, setting the platform to unspecified if it has not been set. But also considering the case where a platform can be set by passing in the platform key:value in the payload. This fixes the error that is being thrown by payload-response.js on line 60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialogflow's fulfillment request has a payload in a different format than what this library expects so it throws an error. This was fixed.
There was a syntactical error which was causing the webhook to throw an exception when an intent was not defined in fulfillment. This was fixed.
In telephony, the agent.end was not sending the correct JSON that dialogflow expects to end the call. This was fixed too.