Skip to content

Update pydicom #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 9, 2025
Merged

Update pydicom #383

merged 7 commits into from
Jan 9, 2025

Conversation

darcymason
Copy link
Contributor

@darcymason darcymason commented Jan 2, 2025 •
edited by bastula
Loading

Fix forcing of older pydicom version. Closes #380.

@darcymason
Update pydicom supported to >=2.4..0
a343210 
* fix DVH repr problems with 'np.int(...) repr'
* collections.Callable -> collections.abc.Callable
@darcymason
Resolve fixing of file_meta info
690eebc
@darcymason
Update workflows for testing pydicom 2.4, 3.X
8cb2e37 
* update some of the actions script versions
@darcymason
Fix style and import issues
b18a932
@darcymason
Fix syntax
e7f9bb8
@darcymason
Update Python versions in setup.py
9ed6ac8 
* make pydicom versions in build name more obvious
@darcymason
Fix force of old pydicom
dc0a2e9
@darcymason
Copy link
Contributor Author

@bastula, I think this is ready for review, except for the "build 3.7" etc. awaiting status, which I hope you understand and can deal with.
Apologies for the multiple PRs, I seem to have muddled things up between pushes to my fork and directly to here.

One note on what was done -- I just copied in the old fix_meta_info from pydicom 2.4 to maintain the same behavior. That will need updating again by pydicom 4.X because of deprecation of Dataset.is_little_endian and .is_implicit_VR. However, pydicom 4.X won't be happening for a long time, and perhaps dicompyler-core can just drop pydicom 2.4 by then.

@bastula
Copy link
Member

bastula commented Jan 8, 2025

Thanks @darcymason for working on this. I will review this week. Looks good from a cursory glance.

@bastula bastula merged commit 209c17c into dicompyler:master Jan 9, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastula bastula bastula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update imports for pydicom >= 3.0
2 participants
@darcymason @bastula