Skip to content

fixes noise added to spectral embedding #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomhaber
Copy link

The same (scalar) noise is added to all values in the spectral embedding. Noise should actually be added to every point/coordinate independently.

@dillondaudert
Copy link
Owner

Broadcasting the randn should generate independent noise for each element. Perhaps you could clarify what the change here does with an example?

@tomhaber
Copy link
Author

Oh wow, I did not expect that behavior at all. My change does exactly the same then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants