-
Notifications
You must be signed in to change notification settings - Fork 55
Add FlatGeobuf element #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bb6226d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@spwoodcock is attempting to deploy a commit to the Daniel Imfeld's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Just FYI since this requires runes it's going to be a bit before this merges though.
The existing PR that you referenced only updates the docs site to use Svelte 5. I'm going to do a release at some point that is a breaking change to make this package only work with Svelte 5, but that's going to require an effort to at least update the slots/snippets and events handling to work with Svelte 5
I don't have a lot of time to work on that right now, but hope to create a next
branch later this month to start the work, and I can merge this one into that branch when I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this one
The |
Nice! Happy to keep contributing to this lib 😄 Svelte 5 is fully backward compatible with Svelte 4 syntax, so the upgrade could still be done without migrating all the syntax. Of course this would be a breaking major version increment. The upgrade should be done over time, but it could be gradual and community supported if time is limited 👍 I currently use this lib in a Svelte 5 project without issues |
24337a3
to
bb6226d
Compare
Finally rebased this & updated the syntax to match latest library changed 👍 One small issue on the example page:
Sorry, I didn't have time to dig into why this is happening, but it doesn't affect the rendering and seems like a cleanup operation that probably isn't essential to functionality. All set I think @dimfeld! |
Issue
Solution
extent={bbox}
extent={polygonGeojson}
extractGeomCols
prop, when set to true will extract the first geometry from within a GeometryCollection. This is a bit of a hack required so that properties can be extracted alongside the geometry when working with PostGIS.metadataFunc={funcHere}
to handle flatgeobuf metadata on fetch.Note
This component uses Svelte 5 syntax, with the PR anticipating the merge of #197
I had some issues with the rendering orders that are hopefully fixed by the functions I used from
context
andsource
logic.Please let me know if I should change anything here!
Screenshot