Skip to content

Conversation

@chouchouji
Copy link
Contributor

Hi, @rijkvanzanten. I try to run pnpm build and notice that all imports from @vueuse/core is externalized.

image

I think we should add it to peerDependencies or bundle it in dist. For me, the second choice is best. Maybe some developers don't tend to use this library. We should consider avoiding forcing developers to be limited to a specific library.

You can check the result of incuding @vueuse/core

image

If you don't think so, just feel free to close this pr. Thanks very much.

@rijkvanzanten
Copy link
Member

Hm the downside of that is that the bundle size gets a lot larger for people that do use vue-use already as it's not de-duplicated. I do think it's safe to say this component is generally used within projects that have a bundler themselves as well 🤔

@chouchouji
Copy link
Contributor Author

Hm the downside of that is that the bundle size gets a lot larger for people that do use vue-use already as it's not de-duplicated. I do think it's safe to say this component is generally used within projects that have a bundler themselves as well 🤔

Yes, I approve it. In order to avoid confusion, we should think to add some tips in readme or just add @vueuse/core to peerDependencies .

@rijkvanzanten
Copy link
Member

we should think to add some tips in readme or just add @vueuse/core to peerDependencies .

Lets do that! 🙂

@chouchouji chouchouji deleted the chore-publish branch August 26, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants