chore: ensure '@vueuse/core' is not externalized in tsdown configuration #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @rijkvanzanten. I try to run
pnpm buildand notice that all imports from@vueuse/coreis externalized.I think we should add it to
peerDependenciesor bundle it in dist. For me, the second choice is best. Maybe some developers don't tend to use this library. We should consider avoiding forcing developers to be limited to a specific library.You can check the result of incuding
@vueuse/coreIf you don't think so, just feel free to close this pr. Thanks very much.