more than 1 country?

[onlyjsmith]

This line looks like it can return more than 1 country if the points are across boundaries. Think this will cause bugs in most functions that use country, expecting it to be a single string.

fn-covariate-extractor/fn-covariate-extractor/function/function.R

Line 109 in cf35f60

country = as.character(coords2country(st_coordinates(points))[1])

[HughSt]

It only works for 1 country. This line gets the country from the 1st coordinate. So if the points span 2 countries, it will only get layers for the country in which the first point lies.

[onlyjsmith]

Ah, right - that's what the [1] does?

So will the bug then be that: points in two countries will only trigger download of data for 1 country, so we'd get nulls/NAs for points in 1 country?

[HughSt]

Yes I think so. So far, accessing data across country-boundaries hasn't been a priority. Moving to icebox for the moment.

[onlyjsmith]

I've added something to the SPECS.md to explain this (commit 32a0b97). Might help us with debugging at some point!