DEV: Use explicit serializers for all models (#691)

Author: jancernik

app/controllers/discourse_ai/admin/ai_llms_controller.rb

@@ -36,9 +36,9 @@ def create
         llm_model = LlmModel.new(ai_llm_params)
         if llm_model.save
           llm_model.toggle_companion_user
-          render json: { ai_persona: llm_model }, status: :created
+          render json: { ai_persona: LlmModelSerializer.new(llm_model) }, status: :created
         else
-          render_json_error llm_model
+          render_json_error LlmModelSerializer.new(llm_model)
         end
       end
 
@@ -47,9 +47,9 @@ def update
 
         if llm_model.update(ai_llm_params(updating: llm_model))
           llm_model.toggle_companion_user
-          render json: llm_model
+          render json: LlmModelSerializer.new(llm_model)
         else
-          render_json_error llm_model
+          render_json_error LlmModelSerializer.new(llm_model)
         end
       end
 

app/controllers/discourse_ai/admin/ai_personas_controller.rb

@@ -43,7 +43,10 @@ def create
         if ai_persona.save
           RagDocumentFragment.link_persona_and_uploads(ai_persona, attached_upload_ids)
 
-          render json: { ai_persona: ai_persona }, status: :created
+          render json: {
+                   ai_persona: LocalizedAiPersonaSerializer.new(ai_persona, root: false),
+                 },
+                 status: :created
         else
           render_json_error ai_persona
         end
@@ -58,17 +61,17 @@ def update
         if @ai_persona.update(ai_persona_params.except(:rag_uploads))
           RagDocumentFragment.update_persona_uploads(@ai_persona, attached_upload_ids)
 
-          render json: @ai_persona
+          render json: LocalizedAiPersonaSerializer.new(@ai_persona, root: false)
         else
-          render_json_error @ai_persona
+          render_json_error LocalizedAiPersonaSerializer.new(@ai_persona, root: false)
         end
       end
 
       def destroy
         if @ai_persona.destroy
           head :no_content
         else
-          render_json_error @ai_persona
+          render_json_error LocalizedAiPersonaSerializer.new(@ai_persona, root: false)
         end
       end
 

app/controllers/discourse_ai/ai_bot/bot_controller.rb

@@ -18,7 +18,7 @@ def show_debug_info
 
         debug_info = AiApiAuditLog.where(post: posts).order(created_at: :desc).first
 
-        render json: debug_info, status: 200
+        render json: AiApiAuditLogSerializer.new(debug_info, root: false), status: 200
       end
 
       def stop_streaming_response

app/serializers/ai_api_audit_log_serializer.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+class AiApiAuditLogSerializer < ApplicationSerializer
+  attributes :id,
+             :provider_id,
+             :user_id,
+             :request_tokens,
+             :response_tokens,
+             :raw_request_payload,
+             :raw_response_payload,
+             :topic_id,
+             :post_id,
+             :feature_name,
+             :language_model,
+             :created_at
+end

app/serializers/ai_chat_channel_serializer.rb

@@ -3,6 +3,17 @@
 class AiChatChannelSerializer < ApplicationSerializer
   attributes :id, :chatable, :chatable_type, :chatable_url, :slug
 
+  def chatable
+    case object.chatable_type
+    when "Category"
+      BasicCategorySerializer.new(object.chatable, root: false).as_json
+    when "DirectMessage"
+      Chat::DirectMessageSerializer.new(object.chatable, scope: scope, root: false).as_json
+    when "Site"
+      nil
+    end
+  end
+
   def title
     # Display all participants for a DM.
     # For category channels, the argument is ignored.