DEV: Temporarily suppress diff animation as we fix issues (#1341)

The diff animation introduced in #1332 and with attempts to improve it in #1338 still has various issues. As we work on a fix, we want to revert the animation to simply stream the diff without animation so users are not left with a janky unusable experience.

Author: keegangeorge

assets/javascripts/discourse/components/modal/diff-modal.gjs

@@ -23,23 +23,21 @@ export default class ModalDiffModal extends Component {
 
   @tracked loading = false;
   @tracked finalResult = "";
+  @tracked showcasedDiff = "";
   @tracked diffStreamer = new DiffStreamer(this.args.model.selectedText);
   @tracked suggestion = "";
   @tracked
   smoothStreamer = new SmoothStreamer(
     () => this.suggestion,
     (newValue) => (this.suggestion = newValue)
   );
+  @tracked isStreaming = false;
 
   constructor() {
     super(...arguments);
     this.suggestChanges();
   }
 
-  get isStreaming() {
-    return this.diffStreamer.isStreaming || this.smoothStreamer.isStreaming;
-  }
-
   get primaryBtnLabel() {
     return this.loading
       ? i18n("discourse_ai.ai_helper.context_menu.loading")
@@ -64,12 +62,25 @@ export default class ModalDiffModal extends Component {
 
   @action
   async updateResult(result) {
+    // TODO(@keegan)
+    // Temporarily we are removing the animation using the diff streamer
+    // and simply showing the diff streamed without a proper animation
+    // while we figure things out
+    // so that things are not too janky in the meantime.
     this.loading = false;
+    this.isStreaming = true;
 
     if (result.done) {
       this.finalResult = result.result;
     }
 
+    this.showcasedDiff = result.diff;
+
+    if (result.done) {
+      this.loading = false;
+      this.isStreaming = false;
+    }
+
     if (this.args.model.showResultAsDiff) {
       this.diffStreamer.updateResult(result, "result");
     } else {
@@ -140,12 +151,11 @@ export default class ModalDiffModal extends Component {
                 "composer-ai-helper-modal__suggestion"
                 "streamable-content"
                 (if this.isStreaming "streaming")
-                (if this.diffStreamer.isThinking "thinking")
                 (if @model.showResultAsDiff "inline-diff")
               }}
             >
               {{#if @model.showResultAsDiff}}
-                {{htmlSafe this.diffStreamer.diff}}
+                {{htmlSafe this.showcasedDiff}}
               {{else}}
                 {{#if this.smoothStreamer.isStreaming}}
                   <CookText

lib/ai_helper/assistant.rb

@@ -185,11 +185,9 @@ def stream_prompt(completion_prompt, input, user, channel, force_default_locale:
           if (streamed_result.length > 10 && (Time.now - start > 0.3)) || Rails.env.test?
             sanitized = sanitize_result(streamed_result)
 
-            if DiscourseAi::Utils::DiffUtils::SafetyChecker.safe_to_stream?(sanitized)
-              payload = { result: sanitized, diff: streamed_diff, done: false }
-              publish_update(channel, payload, user)
-              start = Time.now
-            end
+            payload = { result: sanitized, diff: streamed_diff, done: false }
+            publish_update(channel, payload, user)
+            start = Time.now
           end
         end