+
+ {{icon this.caretIcon}}
+ {{this.exampleTitle}}
+
+ {{#unless this.collapsed}}
+ <@examplesCollection.Collection as |exPair pairIdx|>
+
+
+
+
+
+ {{#unless @system}}
+ <@form.Container>
+ <@form.Button
+ @action={{this.deletePair}}
+ @label="discourse_ai.ai_persona.examples.remove"
+ class="ai-persona-editor__delete_example btn-danger"
+ />
+
+ {{/unless}}
+ {{/unless}}
+
+}
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 04901dc26..a043ae315 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -330,6 +330,14 @@ en:
modal:
root_title: "Response structure"
key_title: "Key"
+ examples:
+ title: Examples
+ examples_help: Simulate previous interactions with the LLM and ground it to produce better result.
+ new: New example
+ remove: Delete example
+ collapsable_title: "Example #%{number}"
+ user: "User message"
+ model: "Model response"
list:
enabled: "AI Bot?"
diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
index 1c3351c9f..00a71cd31 100644
--- a/config/locales/server.en.yml
+++ b/config/locales/server.en.yml
@@ -495,6 +495,9 @@ en:
other: "We couldn't delete this model because %{settings} are using it. Update the settings and try again."
cannot_edit_builtin: "You can't edit a built-in model."
+ personas:
+ malformed_examples: "The given examples have the wrong format."
+
embeddings:
delete_failed: "This model is currently in use. Update the `ai embeddings selected model` first."
cannot_edit_builtin: "You can't edit a built-in model."
diff --git a/db/fixtures/personas/603_ai_personas.rb b/db/fixtures/personas/603_ai_personas.rb
index 7d52e8a9e..27e6d479f 100644
--- a/db/fixtures/personas/603_ai_personas.rb
+++ b/db/fixtures/personas/603_ai_personas.rb
@@ -74,6 +74,8 @@ def from_setting(setting_name)
persona.response_format = instance.response_format
+ persona.examples = instance.examples
+
persona.system_prompt = instance.system_prompt
persona.top_p = instance.top_p
persona.temperature = instance.temperature
diff --git a/db/migrate/20250508154953_add_examples_to_personas.rb b/db/migrate/20250508154953_add_examples_to_personas.rb
new file mode 100644
index 000000000..2cf12912c
--- /dev/null
+++ b/db/migrate/20250508154953_add_examples_to_personas.rb
@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddExamplesToPersonas < ActiveRecord::Migration[7.2]
+ def change
+ add_column :ai_personas, :examples, :jsonb
+ end
+end
diff --git a/lib/personas/persona.rb b/lib/personas/persona.rb
index a8b087850..a4443dcc0 100644
--- a/lib/personas/persona.rb
+++ b/lib/personas/persona.rb
@@ -164,6 +164,10 @@ def response_format
nil
end
+ def examples
+ []
+ end
+
def available_tools
self
.class
@@ -173,11 +177,7 @@ def available_tools
end
def craft_prompt(context, llm: nil)
- system_insts =
- system_prompt.gsub(/\{(\w+)\}/) do |match|
- found = context.lookup_template_param(match[1..-2])
- found.nil? ? match : found.to_s
- end
+ system_insts = replace_placeholders(system_prompt, context)
prompt_insts = <<~TEXT.strip
#{system_insts}
@@ -206,10 +206,21 @@ def craft_prompt(context, llm: nil)
prompt_insts << fragments_guidance if fragments_guidance.present?
+ post_system_examples = []
+
+ if examples.present?
+ examples.flatten.each_with_index do |e, idx|
+ post_system_examples << {
+ content: replace_placeholders(e, context),
+ type: (idx + 1).odd? ? :user : :model,
+ }
+ end
+ end
+
prompt =
DiscourseAi::Completions::Prompt.new(
prompt_insts,
- messages: context.messages,
+ messages: post_system_examples.concat(context.messages),
topic_id: context.topic_id,
post_id: context.post_id,
)
@@ -239,6 +250,13 @@ def allow_partial_tool_calls?
protected
+ def replace_placeholders(content, context)
+ content.gsub(/\{(\w+)\}/) do |match|
+ found = context.lookup_template_param(match[1..-2])
+ found.nil? ? match : found.to_s
+ end
+ end
+
def tool_instance(tool_call, bot_user:, llm:, context:, existing_tools:)
function_id = tool_call.id
function_name = tool_call.name
diff --git a/lib/personas/summarizer.rb b/lib/personas/summarizer.rb
index 64540ff08..c1eefe89c 100644
--- a/lib/personas/summarizer.rb
+++ b/lib/personas/summarizer.rb
@@ -32,6 +32,15 @@ def system_prompt
def response_format
[{ key: "summary", type: "string" }]
end
+
+ def examples
+ [
+ [
+ "Here are the posts inside XML tags:\n\n1) user1 said: I love Mondays 2) user2 said: I hate Mondays\n\nGenerate a concise, coherent summary of the text above maintaining the original language.",
+ "Two users are sharing their feelings toward Mondays. [user1]({resource_url}/1) hates them, while [user2]({resource_url}/2) loves them.",
+ ],
+ ]
+ end
end
end
end
diff --git a/lib/summarization/strategies/topic_summary.rb b/lib/summarization/strategies/topic_summary.rb
index 9361e50ba..f06b67abd 100644
--- a/lib/summarization/strategies/topic_summary.rb
+++ b/lib/summarization/strategies/topic_summary.rb
@@ -44,20 +44,7 @@ def as_llm_messages(contents)
input =
contents.map { |item| "(#{item[:id]} #{item[:poster]} said: #{item[:text]} " }.join
- messages = []
- messages << {
- type: :user,
- content:
- "Here are the posts inside XML tags:\n\n1) user1 said: I love Mondays 2) user2 said: I hate Mondays\n\nGenerate a concise, coherent summary of the text above maintaining the original language.",
- }
-
- messages << {
- type: :model,
- content:
- "Two users are sharing their feelings toward Mondays. [user1](#{resource_path}/1) hates them, while [user2](#{resource_path}/2) loves them.",
- }
-
- messages << { type: :user, content: <<~TEXT.strip }
+ [{ type: :user, content: <<~TEXT.strip }]
#{content_title.present? ? "The discussion title is: " + content_title + ".\n" : ""}
Here are the posts, inside XML tags:
@@ -67,8 +54,6 @@ def as_llm_messages(contents)
Generate a concise, coherent summary of the text above maintaining the original language.
TEXT
-
- messages
end
private
diff --git a/spec/lib/personas/persona_spec.rb b/spec/lib/personas/persona_spec.rb
index 25f12914b..e3c96e348 100644
--- a/spec/lib/personas/persona_spec.rb
+++ b/spec/lib/personas/persona_spec.rb
@@ -8,6 +8,7 @@ def tools
DiscourseAi::Personas::Tools::Image,
]
end
+
def system_prompt
<<~PROMPT
{site_url}
@@ -445,6 +446,29 @@ def stub_fragments(fragment_count, persona: ai_persona)
expect(crafted_system_prompt).not_to include("fragment-n10") # Fragment #10 not included
end
end
+
+ context "when the persona has examples" do
+ fab!(:examples_persona) do
+ Fabricate(
+ :ai_persona,
+ examples: [["User message", "assistant response"]],
+ allowed_group_ids: [Group::AUTO_GROUPS[:trust_level_0]],
+ )
+ end
+
+ it "includes them before the context messages" do
+ custom_persona =
+ DiscourseAi::Personas::Persona.find_by(id: examples_persona.id, user: user).new
+
+ post_system_prompt_msgs = custom_persona.craft_prompt(with_cc).messages.last(3)
+
+ expect(post_system_prompt_msgs).to contain_exactly(
+ { content: "User message", type: :user },
+ { content: "assistant response", type: :model },
+ { content: "Tell me the time", type: :user },
+ )
+ end
+ end
end
end
end
diff --git a/spec/models/ai_persona_spec.rb b/spec/models/ai_persona_spec.rb
index c776e699e..0e6b9d13d 100644
--- a/spec/models/ai_persona_spec.rb
+++ b/spec/models/ai_persona_spec.rb
@@ -1,90 +1,79 @@
# frozen_string_literal: true
RSpec.describe AiPersona do
+ subject(:basic_persona) do
+ AiPersona.new(
+ name: "test",
+ description: "test",
+ system_prompt: "test",
+ tools: [],
+ allowed_group_ids: [],
+ )
+ end
+
fab!(:llm_model)
fab!(:seeded_llm_model) { Fabricate(:llm_model, id: -1) }
it "validates context settings" do
- persona =
- AiPersona.new(
- name: "test",
- description: "test",
- system_prompt: "test",
- tools: [],
- allowed_group_ids: [],
- )
+ expect(basic_persona.valid?).to eq(true)
- expect(persona.valid?).to eq(true)
-
- persona.max_context_posts = 0
- expect(persona.valid?).to eq(false)
- expect(persona.errors[:max_context_posts]).to eq(["must be greater than 0"])
+ basic_persona.max_context_posts = 0
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:max_context_posts]).to eq(["must be greater than 0"])
- persona.max_context_posts = 1
- expect(persona.valid?).to eq(true)
+ basic_persona.max_context_posts = 1
+ expect(basic_persona.valid?).to eq(true)
- persona.max_context_posts = nil
- expect(persona.valid?).to eq(true)
+ basic_persona.max_context_posts = nil
+ expect(basic_persona.valid?).to eq(true)
end
it "validates tools" do
- persona =
- AiPersona.new(
- name: "test",
- description: "test",
- system_prompt: "test",
- tools: [],
- allowed_group_ids: [],
- )
-
Fabricate(:ai_tool, id: 1)
Fabricate(:ai_tool, id: 2, name: "Archie search", tool_name: "search")
- expect(persona.valid?).to eq(true)
+ expect(basic_persona.valid?).to eq(true)
- persona.tools = %w[search image_generation]
- expect(persona.valid?).to eq(true)
+ basic_persona.tools = %w[search image_generation]
+ expect(basic_persona.valid?).to eq(true)
- persona.tools = %w[search image_generation search]
- expect(persona.valid?).to eq(false)
- expect(persona.errors[:tools]).to eq(["Can not have duplicate tools"])
+ basic_persona.tools = %w[search image_generation search]
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:tools]).to eq(["Can not have duplicate tools"])
- persona.tools = [["custom-1", { test: "test" }, false], ["custom-2", { test: "test" }, false]]
- expect(persona.valid?).to eq(true)
- expect(persona.errors[:tools]).to eq([])
+ basic_persona.tools = [
+ ["custom-1", { test: "test" }, false],
+ ["custom-2", { test: "test" }, false],
+ ]
+ expect(basic_persona.valid?).to eq(true)
+ expect(basic_persona.errors[:tools]).to eq([])
- persona.tools = [["custom-1", { test: "test" }, false], ["custom-1", { test: "test" }, false]]
- expect(persona.valid?).to eq(false)
- expect(persona.errors[:tools]).to eq(["Can not have duplicate tools"])
+ basic_persona.tools = [
+ ["custom-1", { test: "test" }, false],
+ ["custom-1", { test: "test" }, false],
+ ]
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:tools]).to eq(["Can not have duplicate tools"])
- persona.tools = [
+ basic_persona.tools = [
["custom-1", { test: "test" }, false],
["custom-2", { test: "test" }, false],
"image_generation",
]
- expect(persona.valid?).to eq(true)
- expect(persona.errors[:tools]).to eq([])
+ expect(basic_persona.valid?).to eq(true)
+ expect(basic_persona.errors[:tools]).to eq([])
- persona.tools = [
+ basic_persona.tools = [
["custom-1", { test: "test" }, false],
["custom-2", { test: "test" }, false],
"Search",
]
- expect(persona.valid?).to eq(false)
- expect(persona.errors[:tools]).to eq(["Can not have duplicate tools"])
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:tools]).to eq(["Can not have duplicate tools"])
end
it "allows creation of user" do
- persona =
- AiPersona.create!(
- name: "test",
- description: "test",
- system_prompt: "test",
- tools: [],
- allowed_group_ids: [],
- )
-
- user = persona.create_user!
+ user = basic_persona.create_user!
expect(user.username).to eq("test_bot")
expect(user.name).to eq("Test")
expect(user.bot?).to be(true)
@@ -223,25 +212,17 @@
end
it "validates allowed seeded model" do
- persona =
- AiPersona.new(
- name: "test",
- description: "test",
- system_prompt: "test",
- tools: [],
- allowed_group_ids: [],
- default_llm_id: seeded_llm_model.id,
- )
+ basic_persona.default_llm_id = seeded_llm_model.id
SiteSetting.ai_bot_allowed_seeded_models = ""
- expect(persona.valid?).to eq(false)
- expect(persona.errors[:default_llm]).to include(
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:default_llm]).to include(
I18n.t("discourse_ai.llm.configuration.invalid_seeded_model"),
)
SiteSetting.ai_bot_allowed_seeded_models = "-1"
- expect(persona.valid?).to eq(true)
+ expect(basic_persona.valid?).to eq(true)
end
it "does not leak caches between sites" do
@@ -268,6 +249,7 @@
system_prompt: "system persona",
tools: %w[Search Time],
response_format: [{ key: "summary", type: "string" }],
+ examples: [%w[user_msg1 assistant_msg1], %w[user_msg2 assistant_msg2]],
system: true,
)
end
@@ -302,6 +284,40 @@
ActiveRecord::RecordInvalid,
)
end
+
+ it "doesn't accept changes to examples" do
+ other_examples = [%w[user_msg1 assistant_msg1]]
+
+ expect { system_persona.update!(examples: other_examples) }.to raise_error(
+ ActiveRecord::RecordInvalid,
+ )
+ end
+ end
+ end
+
+ describe "validates examples format" do
+ it "doesn't accept examples that are not arrays" do
+ basic_persona.examples = [1]
+
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:examples].first).to eq(
+ I18n.t("discourse_ai.personas.malformed_examples"),
+ )
+ end
+
+ it "doesn't accept examples that don't come in pairs" do
+ basic_persona.examples = [%w[user_msg1]]
+
+ expect(basic_persona.valid?).to eq(false)
+ expect(basic_persona.errors[:examples].first).to eq(
+ I18n.t("discourse_ai.personas.malformed_examples"),
+ )
+ end
+
+ it "works when example is well formatted" do
+ basic_persona.examples = [%w[user_msg1 assistant1]]
+
+ expect(basic_persona.valid?).to eq(true)
end
end
end
diff --git a/spec/requests/admin/ai_personas_controller_spec.rb b/spec/requests/admin/ai_personas_controller_spec.rb
index 0e5662f5e..17b7fe34e 100644
--- a/spec/requests/admin/ai_personas_controller_spec.rb
+++ b/spec/requests/admin/ai_personas_controller_spec.rb
@@ -186,6 +186,7 @@
question_consolidator_llm_id: llm_model.id,
forced_tool_count: 2,
response_format: [{ key: "summary", type: "string" }],
+ examples: [%w[user_msg1 assistant_msg1], %w[user_msg2 assistant_msg2]],
}
end
@@ -213,6 +214,7 @@
expect(persona_json["response_format"].map { |rf| rf["key"] }).to contain_exactly(
"summary",
)
+ expect(persona_json["examples"]).to eq(valid_attributes[:examples])
persona = AiPersona.find(persona_json["id"])