This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Clean up after #677 #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to b863ddc Ruby: * Validate `summary` (the column is `not null`) * Fix `name` validation (the column has `max_length` 100) * Fix table annotations * Accept missing `parameter` attributes (`required, `enum`, `enum_values`) JS: * Use native classes * Don't use ember's array extensions * Add explicit service injections * Correct class names * Use `||=` operator * Use `store` service to create records * Remove unused service injections * Extract consts * Group actions together * Use `async`/`await` * Use `withEventValue` * Sort html attributes * Use DButtons `@label` arg * Use `input` elements instead of Ember's `Input` component (same w/ textarea) * Remove `btn-default` class (automatically applied by DButton) * Don't mix `I18n.t` and `i18n` in the same template * Don't track props that aren't used in a template * Correct invalid `target.value` code * Remove unused/invalid `this.parameter`/`onChange` code * Whitespace * Use the new service import `inject as service` -> `service` * Use `Object.entries()` * Add missing i18n strings * Fix an error in `addEnumValue` (calling `pushObject` on `undefined`) * Use `TrackedArray`/`TrackedObject` * Transform tool `parameters` keys (`enumValues` -> `enum_values`)
SamSaffron
reviewed
Jun 27, 2024
|
|
||
| setupController(controller, model) { | ||
| this._super(controller, model); | ||
| return allTools.find((tool) => tool.id === id); |
There was a problem hiding this comment.
@martin-brennan and you need to have a chat :) he keeps pushing me to use findBy ... I don't really care, I do get that find is a fraction of a micro second faster.
SamSaffron
approved these changes
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to b863ddc
Ruby:
summary(the column isnot null)namevalidation (the column hasmax_length100)parameterattributes (required,enum,enum_values`)JS:
||=operatorstoreservice to create recordsasync/awaitwithEventValue@labelarginputelements instead of Ember'sInputcomponent (same w/ textarea)btn-defaultclass (automatically applied by DButton)I18n.tandi18nin the same templatetarget.valuecodethis.parameter/onChangecodeinject as service->serviceObject.entries()addEnumValue(callingpushObjectonundefined)TrackedArray/TrackedObjectparameterskeys (enumValues->enum_values)