[bug] checkboxmultipleselect is a radio

[rosscdh]

as per https://github.com/django/django/blob/main/django/forms/widgets.py#L839

unfortunately the widget inherits from radioselect which means that isinstance will return true an show a radio select due to the order in https://github.com/django-crispy-forms/crispy-tailwind/blob/main/crispy_tailwind/templates/tailwind/field.html#L20

as is demonstrated here

(Pdb) isinstance(form.fields.get('infrastructure').widget, forms.CheckboxSelectMultiple)
True
(Pdb) isinstance(form.fields.get('infrastructure').widget, forms.RadioSelect)
True

a working fix would be to test for the class name rather?

 form.fields.get('infrastructure').widget.__class__.__name__
'CheckboxSelectMultiple'

[dpjanes]

Seconded on this one:

This is how django-crispy-forms handles it:

https://github.com/django-crispy-forms/django-crispy-forms/blob/main/crispy_forms/templatetags/crispy_forms_field.py

    return isinstance(field.field.widget, forms.RadioSelect) and not isinstance(
        field.field.widget, forms.CheckboxSelectMultiple
    )

[GitRon]

Hi @rosscdh!

Nice to meet you here! 😄

What do you say about @dpjanes suggestion how crispy forms core handles this?

Best
Ronny

[GitRon]

Hi @rosscdh and @dpjanes!

I had a second look at this issue. I think we get in some trouble once somebody starts inheriting from any base class, right?

I asked GPT to see if I'm missing something, and it suggested

type(my_class) is MyClass

This would cover the case Ross mentioned but once I start inheriting, this doesn't work. So #127 is not working - am I right?

Thx for your effort but I think we can close the PR #127.

Still, it's a valid issue and I'm open for suggestions.

Best from Cologne
Ronny

[rosscdh]

Yep Inheritance would certainly put a spanner in the works!

…

On Wed, 4 Dec 2024, 02:31 Ronny V., ***@***.***> wrote: Hi @rosscdh <https://github.com/rosscdh> and @dpjanes <https://github.com/dpjanes>! I had a second look at this issue. I think we get in some trouble once somebody starts inheriting from any base class, right? I asked GPT to see if I'm missing something, and it suggested type(my_class) is MyClass This would cover the case Ross mentioned but once I start inheriting, this doesn't work. So #127 <#127> is not working - am I right? Thx for your effort but I think we can close the PR #127 <#127>. Still, it's a valid issue and I'm open for suggestions. Best from Cologne Ronny — Reply to this email directly, view it on GitHub <#126 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADA6MQE53GXFQKJXBCUCDL2DXFDHAVCNFSM6AAAAABS6B6RHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUHA4DQOJXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>