Fix #270

Hackerpilot · Hackerpilot · commit eb50bc9e18d0 · 2015-09-17T23:39:38.000-07:00
diff --git a/src/analysis/unmodified.d b/src/analysis/unmodified.d
@@ -155,7 +155,12 @@ class UnmodifiedFinder:BaseAnalyzer
 
 	override void visit(const TraitsExpression)
 	{
-		// Issue #266. Ignore everything inside of __traits expressions.
+		// issue #266: Ignore unmodified variables inside of `__traits` expressions
+	}
+
+	override void visit(const TypeofExpression)
+	{
+		// issue #270: Ignore unmodified variables inside of `typeof` expressions
 	}
 
 private:
diff --git a/src/analysis/unused.d b/src/analysis/unused.d
@@ -318,7 +318,12 @@ class UnusedVariableCheck : BaseAnalyzer
 
 	override void visit(const TraitsExpression)
 	{
-		// Issue #266. Ignore everything inside of __traits expressions.
+		// issue #266: Ignore unused variables inside of `__traits` expressions
+	}
+
+	override void visit(const TypeofExpression)
+	{
+		// issue #270: Ignore unused variables inside of `typeof` expressions
 	}
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,12 @@ class UnmodifiedFinder:BaseAnalyzer`
`155`	`155`
`156`	`156`	`override void visit(const TraitsExpression)`
`157`	`157`	`{`
`158`		`- // Issue #266. Ignore everything inside of __traits expressions.`
	`158`	+ // issue #266: Ignore unmodified variables inside of `__traits` expressions
	`159`	`+ }`
	`160`	`+`
	`161`	`+ override void visit(const TypeofExpression)`
	`162`	`+ {`
	`163`	+ // issue #270: Ignore unmodified variables inside of `typeof` expressions
`159`	`164`	`}`
`160`	`165`
`161`	`166`	`private:`
Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,12 @@ class UnusedVariableCheck : BaseAnalyzer`
`318`	`318`
`319`	`319`	`override void visit(const TraitsExpression)`
`320`	`320`	`{`
`321`		`- // Issue #266. Ignore everything inside of __traits expressions.`
	`321`	+ // issue #266: Ignore unused variables inside of `__traits` expressions
	`322`	`+ }`
	`323`	`+`
	`324`	`+ override void visit(const TypeofExpression)`
	`325`	`+ {`
	`326`	+ // issue #270: Ignore unused variables inside of `typeof` expressions
`322`	`327`	`}`
`323`	`328`
`324`	`329`	`private:`