Skip to content

[stable] Comment out prototypes for OSX symbols missing on < 10.12#22978

Merged
ibuclaw merged 1 commit into
dlang:stablefrom
ibuclaw:missing_osx_symbols
Apr 21, 2026
Merged

[stable] Comment out prototypes for OSX symbols missing on < 10.12#22978
ibuclaw merged 1 commit into
dlang:stablefrom
ibuclaw:missing_osx_symbols

Conversation

@ibuclaw
Copy link
Copy Markdown
Member

@ibuclaw ibuclaw commented Apr 19, 2026

Phobos uses these (guarded by ie: static if (is(typeof(&utimensat)))), which causes a regression in building complete compiler and runtime.

Preferably we should just add a version mechanism like __traits(getTargetInfo, "macOS_version") - ditto for freebsd version too. But to just unbreak the release, just leave these left for now.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#22978"

@Herringway
Copy link
Copy Markdown
Contributor

Perhaps this __traits(getTargetInfo) could return a struct with a version field.

@ibuclaw ibuclaw changed the title Comment out prototypes for OSX symbols missing on < 10.12 [stable] Comment out prototypes for OSX symbols missing on < 10.12 Apr 19, 2026
@ibuclaw
Copy link
Copy Markdown
Member Author

ibuclaw commented Apr 20, 2026

This is strictly a regression fix, as the prototype didn't exist before in older versions of druntime.

@ibuclaw ibuclaw merged commit d1fbbb1 into dlang:stable Apr 21, 2026
77 of 78 checks passed
@ibuclaw ibuclaw deleted the missing_osx_symbols branch April 21, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants