Skip to content

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Sep 1, 2025

Fixes #10852.

Also updated static if tests for random access range front and opIndex for consistency.

@ntrel ntrel requested a review from PetarKirov as a code owner September 1, 2025 11:34
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10854"

@thewilsonator thewilsonator merged commit 491e4cc into dlang:master Sep 1, 2025
10 checks passed
@ntrel ntrel deleted the cycle-forward branch September 1, 2025 13:16
@safe unittest
{
// forward range
struct R
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have been static struct, though I don't think it matters very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std.range.cycle with a forward-range does not compile
4 participants