Added a new popGrapheme function to std.uni

[dukc]

Since it's Hackathon today, even if I'm not there I decided to do something in similar spirit.

@atilaneves new symbol canditate for phobos, meaning it needs your approval!

[dlang-bot]

Thanks for your pull request and interest in making D better, @dukc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9053"

[dukc]

ping @atilaneves

[atilaneves]

This side note sounds like it should be its own PR.

[dukc]

It is. I felt an added @nogc compability to an existing funtion alone wasn't worth a changelog entry so didn't add one in that PR. But since I'm writing here that graphemeStride is @nogc anyway, which until very recently wasn't the case, I feel it's useful to mention it. As in: "this note applies only with the latest compiler/Phobos".

[atilaneves]

I don't know how useful this is so I would like someone that knows/cares about unicode more than me opines. Not sure who. @rikkimax ?

[rikkimax]

I don't know how useful this is so I would like someone that knows/cares about unicode more than me opines. Not sure who. @rikkimax ?

It allows you to get the grapheme length extracted, so you can slice and dice your string without allocation.

Kinda like graphemeStride except it pops it from the input like parse does.

It is one of those things that if a unicode library is being used you'll end up having a hundred variations of. I see nothing wrong with wanting functions like this.

[dukc]

I don't know how useful this is so I would like someone that knows/cares about unicode more than me opines. Not sure who.

Maybe @John-Colvin ? I think he was supposed to take charge, at one point at least, of my Unicode-related project at Symmetry.

[dukc]

Or alternatively @DmitryOlshansky .

[atilaneves]

I don't know how useful this is so I would like someone that knows/cares about unicode more than me opines. Not sure who. @rikkimax ?

It allows you to get the grapheme length extracted, so you can slice and dice your string without allocation.

Kinda like graphemeStride except it pops it from the input like parse does.

It is one of those things that if a unicode library is being used you'll end up having a hundred variations of. I see nothing wrong with wanting functions like this.

So you're saying we should merge it?

[rikkimax]

I don't know how useful this is so I would like someone that knows/cares about unicode more than me opines. Not sure who. @rikkimax ?

It allows you to get the grapheme length extracted, so you can slice and dice your string without allocation.
Kinda like graphemeStride except it pops it from the input like parse does.
It is one of those things that if a unicode library is being used you'll end up having a hundred variations of. I see nothing wrong with wanting functions like this.

So you're saying we should merge it?

I have no argument against merging. It is sound, it's a variation of something that exists and is worth having different variants for.

The reason I'm avoiding the phrase "merge it" is because of PhobosV3 vs V2. I don't know how you and @LightBender want to handle it.

[LightBender]

I'm good with merging this. Need to get it passing the build though.

[dukc]

Need to get it passing the build though.

Fails at some of the platforms but passes on others, and I'm not doing anything platform-specific. So probably spurious. I'll attempt restarting the tests.

EDIT: Done now. For transparency, I'll note that I made a small change while there: added popGrapheme to the index of the module documentation.

[dukc]

Windows 64bit test is now passing, Mac tests are still failing. Seems to be the same issue in #9056 . I wonder what's going on there. @RazvanN7 do you know?

[RazvanN7]

It seems that the Mac machines are broken. Most likely this PR is not at fault.

[dukc]

Well Mac machines don't apparently have the "required" labes so probably should just ignore them.

@atilaneves good to go now?

[LightBender]

I'm going to merge this as there has been no dissent to date.