Skip to content

Conversation

thewilsonator
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9060"

@thewilsonator thewilsonator added the Review:Trivial typos, formatting, comments label Oct 21, 2024
@RazvanN7 RazvanN7 merged commit ab46287 into dlang:master Oct 21, 2024
8 of 10 checks passed
@thewilsonator thewilsonator deleted the thewilsonator-patch-5 branch October 21, 2024 06:45
@RazvanN7
Copy link
Collaborator

I doubt that string concatenation matters in terms of compile time. Let's not get all confrontational over negligible things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review:Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants