Skip to content

Fix issue 24824 - ensure we exit a child that does not succeed in exec. #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix issue 24824 - ensure we exit a child that does not succeed in exec. #9065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions std/process.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4525,11 +4525,12 @@ else version (Posix)
if (childpid == 0)
{
// Trusted because args and all entries are always zero-terminated
(() @trusted =>
core.sys.posix.unistd.execvp(args[0], &args[0]) ||
perror(args[0]) // failed to execute
)();
return;
(() @trusted {
core.sys.posix.unistd.execvp(args[0], &args[0]);
perror(args[0]);
core.sys.posix.unistd._exit(1);
})();
assert(0, "Child failed to exec");
}
if (browser)
// Trusted because it's allocated via strdup above
Expand Down
Loading