Skip to content

Conversation

@NamelessOne91
Copy link

@NamelessOne91 NamelessOne91 commented Oct 24, 2024

Related to #952 and #1017

This PR adds support for a non-destructive resize when a storage volume size is increased.
Shrinking a storage volume will still ultimately result in destroying the existing one and recreating it.

It would have been possible to handle both cases, shrinking and expanding, in the UpdateContext function, but having a CustomizeDiff function allows to correctly differentiate between a resource update and a destroy + add, notifying it to the user.

@NamelessOne91 NamelessOne91 changed the title Feat: Allow increasing a storage volume size Feat: non-destructive increase of a storage volume size Oct 24, 2024
@scabala
Copy link
Contributor

scabala commented Oct 25, 2024

Thank you for this PR @NamelessOne91!

I'll try to test it in following days and give my feedback.

@NamelessOne91 NamelessOne91 marked this pull request as ready for review October 30, 2024 21:37
@dmacvicar dmacvicar changed the base branch from main to v0.8 November 8, 2025 00:12
@dmacvicar
Copy link
Owner

ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ ℹ️

This contribution is relevant to the legacy version of the provider, which is now in the v0.8 branch of this repository.

Future development is based on a new provider, which is not compatible with this one, nor does share code.

As the new provider solves many issues with the legacy, and to make development in my free time more enjoyable, I have decided to close all PRs for the legacy provider, and to ask to check if the contribution would apply to the new one. This also to encourage trying the new version.

and check the documentation:

You are free to reopen the PR for v0.8, which is targetted now to the v0.8 branch. We may also start a discussion if we can assemble a team of maintainters for the legacy branch. My efforts will go into the new provider.

I ask you to check the new provider and re-evaluate this contribution. 🙏

@dmacvicar dmacvicar closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants