Skip to content

Conversation

@NamelessOne91
Copy link

@NamelessOne91 NamelessOne91 commented Oct 30, 2024

Related to #1041

Adds basic support for managing a libvirt domain title property.

Possible further improvements:

  • have a CustomDiff function that checks if a new title is valid (read: contains no newline characters) BEFORE attempting to replace a domain. Right now when the new title contains newlines the user can still attempt a replacement, the previous domain is destroyed and the new one fails to be created because the title is invalid.
    No bueno.

  • do not force a replacement when the title changes and correctly update it in place. I think libvirt API has no function to update only the title property, so this may require directly updating the domain XML configuration and redefining the domain.

@NamelessOne91 NamelessOne91 marked this pull request as ready for review November 25, 2024 10:39
@dmacvicar dmacvicar changed the base branch from main to v0.8 November 8, 2025 00:12
@dmacvicar
Copy link
Owner

ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ ℹ️

This contribution is relevant to the legacy version of the provider, which is now in the v0.8 branch of this repository.

Future development is based on a new provider, which is not compatible with this one, nor does share code.

As the new provider solves many issues with the legacy, and to make development in my free time more enjoyable, I have decided to close all PRs for the legacy provider, and to ask to check if the contribution would apply to the new one. This also to encourage trying the new version.

and check the documentation:

You are free to reopen the PR for v0.8, which is targetted now to the v0.8 branch. We may also start a discussion if we can assemble a team of maintainters for the legacy branch. My efforts will go into the new provider.

I ask you to check the new provider and re-evaluate this contribution. 🙏

@dmacvicar dmacvicar closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants