Timestamp #27
Merged
Timestamp #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been the default for Firebase for a while now.
Previously, when a document have a reference to another document, we ended up in an infinite loop. This is now prevented by only follow plain objects. This logic makes it easier to reason about the call chain too.
Previous behavior for Server Timestamp was to return UNIX timestamp. This is the correct bahviour still for the client firebase.database library. This change restores this.
Internally date is now stored as Date until returned, where it is converted to Timestamp. This fixes orderBy.
dmurvihill
force-pushed
the
timestamp
branch
from
c30570e to
47f0600
Compare
|
@op, there have been conflicting changes to the API of the |
# Conflicts: # package-lock.json # src/firestore-document-snapshot.js # src/firestore-document.js # src/firestore-query.js # src/utils.js # test/unit/firestore-collection.js # test/unit/utils.js
|
Thanks @op, great PR. Merging now! Look for this in 3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submitting the pull request from the original repo.