Skip to content

Commit e51d945

Browse files
committed
Rename prepareProcessPage to prepareProcessRawInputPage (elastic#130487)
This PR proposes renaming `prepareProcessPage` to `prepareProcessRawInputPage` for two reasons: 1. The name `prepareProcessPage` can be confusing, as it suggests handling all types of input, but it only processes raw input, not intermediate input. 2. I plan to add `prepareProcessIntermediateInputPage`, which can enable optimizations for intermediate pages, such as leveraging ordinals from intermediate results. (cherry picked from commit 285866e)
1 parent 626ea14 commit e51d945

File tree

79 files changed

+86
-86
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+86
-86
lines changed

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ private TypeSpec type() {
195195
builder.addMethod(ctor());
196196
builder.addMethod(intermediateStateDesc());
197197
builder.addMethod(intermediateBlockCount());
198-
builder.addMethod(prepareProcessPage());
198+
builder.addMethod(prepareProcessRawInputPage());
199199
builder.addMethod(addRawInputLoop(INT_VECTOR, blockType(aggParam.type())));
200200
builder.addMethod(addRawInputLoop(INT_VECTOR, vectorType(aggParam.type())));
201201
builder.addMethod(addRawInputLoop(INT_BLOCK, blockType(aggParam.type())));
@@ -310,10 +310,10 @@ private MethodSpec intermediateBlockCount() {
310310
}
311311

312312
/**
313-
* Prepare to process a single page of results.
313+
* Prepare to process a single raw input page.
314314
*/
315-
private MethodSpec prepareProcessPage() {
316-
MethodSpec.Builder builder = MethodSpec.methodBuilder("prepareProcessPage");
315+
private MethodSpec prepareProcessRawInputPage() {
316+
MethodSpec.Builder builder = MethodSpec.methodBuilder("prepareProcessRawInputPage");
317317
builder.addAnnotation(Override.class).addModifiers(Modifier.PUBLIC).returns(GROUPING_AGGREGATOR_FUNCTION_ADD_INPUT);
318318
builder.addParameter(SEEN_GROUP_IDS, "seenGroupIds").addParameter(PAGE, "page");
319319

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBooleanGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctBytesRefGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctDoubleGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctFloatGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctIntGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/CountDistinctLongGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/MaxBooleanGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/MaxBytesRefGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated/org/elasticsearch/compute/aggregation/MaxDoubleGroupingAggregatorFunction.java

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)