-
Notifications
You must be signed in to change notification settings - Fork 5
ui : card-component,whats-next,get-docker & translate : whats-next #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r-ko.github.io into g1nya2-ui-translate
|
|
프리티어 체크가 안된다고 뜨는데 어떤건가요? 상관 있는건가요..? 궁금합니다! 로컬에서 돌릴땐 별 문제 없었습니다 |
|
@krsy0411 프리티어 수정 후, 테스트코드 부분에서 오류가 또 나서, 살펴보니 기존 box-component 테스트코드 지우고 card-component테스트코드 추가해두었습니다! markdown.test.ts 부분입니다! 확인후 머지 부탁드립니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the legacy BoxComponent with a new CardComponent, updates the markdown loader and styles to support cards, and applies these cards to "what’s next" and "get-docker" sections with Korean translations.
- Renamed BoxComponent to CardComponent in code, imports, and tests
- Enhanced
load_md.tsto parse<div>wrappers and card/button tags - Added Tailwind CSS styles for
.cardand integrated cards in docs
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/scripts/components/card-component.ts | Introduces CardComponent and registers card-component |
| src/scripts/load_md.ts | Updates markdown parsing logic to handle card-component and wrappers |
| tests/markdown.test.ts | Adjusts tests to check rendering of card-component |
| src/styles/style.css | Adds base and component styles for .card and custom element display |
| src/scripts/main.ts & components/index.ts | Replaces imports of box-component with card-component |
| public/docs/get-started/.../whats-next.md | Applies card layout and Korean translations to "What’s Next" page |
| public/docs/get-started/get-docker.md | Wraps cards in a <div> grid and replaces boxes with cards |
Comments suppressed due to low confidence (2)
src/scripts/load_md.ts:9
- The
customBlockTokenizerandblockTagRegexextensions are defined but not actually leveraged by your manual split/parsing logic; consider removing them or fully integrating withmarked.useto simplify maintenance.
const blockTagRegex = /^<(card-component)([\s\S]*?)(?:>([\s\S]*?)<\/card-component>|\s*\/)?>/i;
tests/markdown.test.ts:69
- Add a test case for rendering a
<div class="not-prose">...<card-component />...</div>wrapper so we can verify the newdivBlockRegexcorrectly preserves and inserts those blocks.
describe('renderMarkdownWithComponents', () => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| body { | ||
| font-family: 'Noto Sans KR', Arial, sans-serif; | ||
| background: #f8fafc; | ||
| color: #222; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| h1, | ||
| h2, | ||
| h3, | ||
| h4, | ||
| h5, | ||
| h6 { | ||
| font-weight: 700; | ||
| margin-top: 1.5em; | ||
| margin-bottom: 0.5em; | ||
| } | ||
|
|
||
| p { | ||
| margin: 0 0 1em 0; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 전역 스타일을 추가한 이유는 뭘까요?
전역 스타일이 필요없다는 건 아닌데, card-comonent랑은 목적이 다른 코드라는 생각이여서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니다. 이건 들어가고 제가 좀 더 정리해야할 것 같아요. 머지하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 넵!!
위 내용 진행하였습니다.

