Fix multiple splits in a single run #3311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where the way split index was the last item being split, which broken when we separated items into left/right, leading to overwritten values or "token not found" errors. This stops us searching the run as soon as we find a place to split, and also guarantees that we don't try to start looking for a split past the end of the paragraph. I've added a test that reproduces the issue, and then fixed the implementation such that the test passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where the way split index was the last item being split, which broken when we separated items into left/right, leading to overwritten values or "token not found" errors.
This stops us searching the run as soon as we find a place to split, and also guarantees that we don't try to start looking for a split past the end of the paragraph.
I've added a test that reproduces the issue, and then fixed the implementation such that the test passes.