Prevent crashes with weird outbound promotions

Author: dolfies

discord/promotions.py

@@ -113,6 +113,7 @@ class Promotion(Hashable):
 
     __slots__ = (
         'id',
+        '_type',
         'trial_id',
         'starts_at',
         'ends_at',
@@ -145,15 +146,16 @@ def _update(self, data: Union[PromotionPayload, ClaimedPromotionPayload]) -> Non
         promotion: PromotionPayload = data.get('promotion', data)
 
         self.id: int = int(promotion['id'])
+        self._type = promotion.get('promotion_type', 0)  # Unknown enum, observed values 0-2
         self.trial_id: Optional[int] = _get_as_snowflake(promotion, 'trial_id')
         self.starts_at: datetime = parse_time(promotion['start_date'])
         self.ends_at: datetime = parse_time(promotion['end_date'])
         self.claimed_at: Optional[datetime] = parse_time(data.get('claimed_at'))
         self.code: Optional[str] = data.get('code')
         self._flags: int = promotion.get('flags', 0)
 
-        self.outbound_title: str = promotion['outbound_title']
-        self.outbound_description: str = promotion['outbound_redemption_modal_body']
+        self.outbound_title: str = promotion.get('outbound_title', '')
+        self.outbound_description: str = promotion.get('outbound_redemption_modal_body', '')
         self.outbound_link: str = promotion.get(
             'outbound_redemption_page_link',
             promotion.get('outbound_redemption_url_format', '').replace('{code}', self.code or '{code}'),
@@ -163,7 +165,7 @@ def _update(self, data: Union[PromotionPayload, ClaimedPromotionPayload]) -> Non
         self.inbound_description: Optional[str] = promotion.get('inbound_body_text')
         self.inbound_link: Optional[str] = promotion.get('inbound_help_center_link')
         self.inbound_restricted_countries: List[str] = promotion.get('inbound_restricted_countries', [])
-        self.terms_and_conditions: str = promotion['outbound_terms_and_conditions']
+        self.terms_and_conditions: str = promotion.get('outbound_terms_and_conditions', '')
 
     @property
     def flags(self) -> PromotionFlags:

discord/types/promotions.py

@@ -36,14 +36,15 @@ class Promotion(TypedDict):
     trial_id: NotRequired[Snowflake]
     start_date: str
     end_date: str
+    promotion_type: int
     flags: int
-    outbound_title: str
+    outbound_title: NotRequired[str]
     outbound_redemption_modal_body: str
     outbound_redemption_page_link: NotRequired[str]
     outbound_redemption_url_format: NotRequired[str]
     outbound_restricted_countries: NotRequired[List[str]]
     outbound_terms_and_conditions: str
-    inbound_title: NotRequired[str]
+    inbound_header_text: NotRequired[str]
     inbound_body_text: NotRequired[str]
     inbound_help_center_link: NotRequired[str]
     inbound_restricted_countries: NotRequired[List[str]]