Skip to content

Commit db42340

Browse files
authored
Merge pull request #27 from liquidata-inc/zachmu/better-type-checking
Fixed replace tests (broken by my changes to type handling code in Up…
2 parents d1ae6a2 + 1e23033 commit db42340

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

engine_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2367,9 +2367,9 @@ func TestReplaceInto(t *testing.T) {
23672367
[]sql.Row{{
23682368
int64(999), int8(math.MaxInt8), int16(math.MaxInt16), int32(math.MaxInt32), int64(math.MaxInt64),
23692369
uint8(math.MaxUint8), uint16(math.MaxUint16), uint32(math.MaxUint32), uint64(math.MaxUint64),
2370-
float64(math.MaxFloat32), float64(math.MaxFloat64),
2370+
float32(math.MaxFloat32), float64(math.MaxFloat64),
23712371
timeParse(sql.TimestampLayout, "2132-04-05 12:51:36"), timeParse(sql.DateLayout, "2231-11-07"),
2372-
"random text", true, `{"key":"value"}`, "blobdata",
2372+
"random text", true, ([]byte)(`{"key":"value"}`), ([]byte)("blobdata"),
23732373
}},
23742374
},
23752375
{
@@ -2385,9 +2385,9 @@ func TestReplaceInto(t *testing.T) {
23852385
[]sql.Row{{
23862386
int64(999), int8(math.MaxInt8), int16(math.MaxInt16), int32(math.MaxInt32), int64(math.MaxInt64),
23872387
uint8(math.MaxUint8), uint16(math.MaxUint16), uint32(math.MaxUint32), uint64(math.MaxUint64),
2388-
float64(math.MaxFloat32), float64(math.MaxFloat64),
2388+
float32(math.MaxFloat32), float64(math.MaxFloat64),
23892389
timeParse(sql.TimestampLayout, "2132-04-05 12:51:36"), timeParse(sql.DateLayout, "2231-11-07"),
2390-
"random text", true, `{"key":"value"}`, "blobdata",
2390+
"random text", true, ([]byte)(`{"key":"value"}`), ([]byte)("blobdata"),
23912391
}},
23922392
},
23932393
{
@@ -2403,9 +2403,9 @@ func TestReplaceInto(t *testing.T) {
24032403
[]sql.Row{{
24042404
int64(999), int8(-math.MaxInt8 - 1), int16(-math.MaxInt16 - 1), int32(-math.MaxInt32 - 1), int64(-math.MaxInt64 - 1),
24052405
uint8(0), uint16(0), uint32(0), uint64(0),
2406-
float64(math.SmallestNonzeroFloat32), float64(math.SmallestNonzeroFloat64),
2406+
float32(math.SmallestNonzeroFloat32), float64(math.SmallestNonzeroFloat64),
24072407
timeParse(sql.TimestampLayout, "0010-04-05 12:51:36"), timeParse(sql.DateLayout, "0101-11-07"),
2408-
"", false, ``, "",
2408+
"", false, ([]byte)(`""`), ([]byte)(""),
24092409
}},
24102410
},
24112411
{
@@ -2421,9 +2421,9 @@ func TestReplaceInto(t *testing.T) {
24212421
[]sql.Row{{
24222422
int64(999), int8(-math.MaxInt8 - 1), int16(-math.MaxInt16 - 1), int32(-math.MaxInt32 - 1), int64(-math.MaxInt64 - 1),
24232423
uint8(0), uint16(0), uint32(0), uint64(0),
2424-
float64(math.SmallestNonzeroFloat32), float64(math.SmallestNonzeroFloat64),
2424+
float32(math.SmallestNonzeroFloat32), float64(math.SmallestNonzeroFloat64),
24252425
timeParse(sql.TimestampLayout, "0010-04-05 12:51:36"), timeParse(sql.DateLayout, "0101-11-07"),
2426-
"", false, ``, "",
2426+
"", false, ([]byte)(`""`), ([]byte)(""),
24272427
}},
24282428
},
24292429
{

0 commit comments

Comments
 (0)