Ruff: PT011 pytest-raises-too-broad

Author: dominikatrojanowska

ruff.toml

@@ -6210,15 +6210,13 @@ convention = "google"
 "test/TestAbstractActuatorBase.py" = [
     "EXE001",
     "N999",
-    "PT011",
     "PT012",
     "SLF001",
 ]
 "test/TestAbstractMotorBase.py" = [
     "B017",
     "EXE001",
     "N999",
-    "PT011",
     "PT012",
     "SLF001",
 ]
@@ -6227,7 +6225,6 @@ convention = "google"
     "C400",
     "EXE001",
     "N999",
-    "PT011",
     "PT012",
 ]
 "test/TestHardwareObjectBase.py" = [
@@ -6349,7 +6346,6 @@ convention = "google"
     "PIE804",
 ]
 "test/test_resolution.py" = [
-    "PT011",
     "PT012",
     "PT022",
     "SLF001",

test/TestAbstractActuatorBase.py

@@ -80,7 +80,9 @@ def test_value_setting(self, test_object):
 
         if test_object.read_only:
             # test that there is an exception as read only
-            with pytest.raises(ValueError):
+            with pytest.raises(
+                ValueError, match="Attempt to set value for read-only Actuator"
+            ):
                 test_object.set_value(test_object.default_value)
         else:
             # Test set_value with and without a timeout (different code branch)

test/TestAbstractMotorBase.py

@@ -121,7 +121,7 @@ def test_setting_with_tolerance(self, test_object):
         assert not test_object.validate_value(toobig), (
             "Too-big value %s validates as OK" % toobig
         )
-        with pytest.raises(ValueError):
+        with pytest.raises(ValueError, match=r"Invalid value [\d\.]*"):
             test_object.set_value(toobig, timeout=None)
 
         # Must be set first so the next command causes a change
@@ -158,7 +158,7 @@ def test_setting_timeouts_1(self, test_object):
 
         # Must be set first so the next command causes a change
         test_object.set_value(low, timeout=90)
-        with pytest.raises(Exception):
+        with pytest.raises(RuntimeError):
             test_object.set_value(high, timeout=1.0e-6)
 
     def test_setting_timeouts_2(self, test_object):
@@ -174,7 +174,7 @@ def test_setting_timeouts_2(self, test_object):
 
         # Must be set first so the next command causes a change
         test_object.set_value(high, timeout=None)
-        with pytest.raises(Exception):
+        with pytest.raises(RuntimeError):
             test_object.set_value(low, timeout=0)
             test_object.wait_ready(timeout=1.0e-6)
 

test/TestAbstractNStateBase.py

@@ -69,7 +69,7 @@ def test_setting_timeouts_1(self, test_object):
 
         # Must be set first so the next command causes a change
         test_object.set_value(val1, timeout=90)
-        with pytest.raises(Exception):
+        with pytest.raises(RuntimeError):
             test_object.set_value(val2, timeout=1.0e-6)
 
     def test_setting_timeouts_2(self, test_object):
@@ -84,6 +84,6 @@ def test_setting_timeouts_2(self, test_object):
 
         # Must be set first so the next command causes a change
         test_object.set_value(val2, timeout=None)
-        with pytest.raises(Exception):
+        with pytest.raises(RuntimeError):
             test_object.set_value(val1, timeout=0)
             test_object.wait_ready(timeout=1.0e-6)

test/test_resolution.py

@@ -77,7 +77,7 @@ def test_setting_with_tolerance(self, test_object):
             f"Too big value {toobig} validates as OK"
         )
 
-        with pytest.raises(ValueError):
+        with pytest.raises(ValueError, match=r"Invalid value [\d\.]*"):
             test_object.set_value(toobig, timeout=None)
 
         # Must be set first so the next command causes a change