Remove netbird_deployment_mode and simplify instance selection with netbird_mgmt_url

- Removed `netbird_deployment_mode` variable.
- Updated logic to determine instance type based on `netbird_mgmt_url`.

Author: HRGCompany

roles/netbird/README.md

@@ -10,10 +10,7 @@ Role Variables
 --------------
 - `netbird_setup_key`: The key that is used to automate the setup process.
 - `netbird_register`: A true/false defining whether or not register netbird.
-- `netbird_deployment_mode`: Specifies the deployment mode for Netbird. It can be either:
-  - 'cloud-hosted': For deploying Netbird using the cloud-hosted instance.
-  - 'self-hosted': For deploying a self-hosted instance of Netbird.
-- `netbird_mgmt_url`: The management URL for the self-hosted instance. This variable is required if `netbird_deployment_mode` is set to `'self-hosted'`.
+- `netbird_mgmt_url`: The management URL for the self-hosted instance. If not specified, defaults to the cloud-hosted instance (https://api.netbird.io:443).
 
 Dependencies
 ------------

roles/netbird/defaults/main.yml

@@ -1,3 +1,3 @@
 ---
 # defaults file for netbird
-netbird_deployment_mode: 'cloud-hosted'
+netbird_mgmt_url: https://api.netbird.io:443

roles/netbird/tasks/main.yml

@@ -1,11 +1,5 @@
 ---
 # tasks file for netbird
-- name: Check if self-hosted installation comes with a netbird_mgmt_url
-  ansible.builtin.assert:
-    that: netbird_mgmt_url is defined and netbird_mgmt_url != ''
-    fail_msg: "The management URL must be defined and non-empty for self-hosted installations."
-  when: deployment_mode == 'self-hosted'
-
 - name: Check for Netbird Installation
   ansible.builtin.shell:
     cmd: netbird version
@@ -22,20 +16,11 @@
   register: netbird_status
   changed_when: false
   ignore_errors: true
-  when: netbird_deployment_mode is true
-
-- name: Start Netbird (SaaS mode)
-  become: true
-  ansible.builtin.shell: netbird up --setup-key="{{ netbird_setup_key }}"
-  when: 
-    - netbird_deployment_mode is true
-    - "'NeedsLogin' in netbird_status.stdout or 'LoginFailed' in netbird_status.stdout"
-    - deployment_mode == 'cloud-hosted'
+  when: netbird_register is true
 
-- name: Start Netbird (Self-Hosted mode)
+- name: Start Netbird
   become: true
   ansible.builtin.shell: netbird up --setup-key="{{ netbird_setup_key }}" --management-url="{{ netbird_mgmt_url }}"
-  when:
-    - netbird_deployment_mode is true
+  when: 
+    - netbird_register is true
     - "'NeedsLogin' in netbird_status.stdout or 'LoginFailed' in netbird_status.stdout"
-    - deployment_mode == 'self-hosted'