Add support for self-hosted Netbird instances and update README #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented logic to handle `netbird_deployment_mode` . - Added validation to ensure `netbird_management_url` is defined and non-empty when using self-hosted mode. - Updated README with detailed documentation for `netbird_deployment_mode` and `netbird_management_url`.
…etbird_mgmt_url - Removed `netbird_deployment_mode` variable. - Updated logic to determine instance type based on `netbird_mgmt_url`.
|
@spam-n-eggs : Can you review this change? It adds a simple change to allow the use of self-hosted instances. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for self-hosted Netbird instances by updating the instance command logic and documentation.
- Updated the command to check the Netbird version and start Netbird with a management URL parameter.
- Introduced a new default variable for netbird_mgmt_url and updated the README to document this option.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roles/netbird/tasks/main.yml | Updated shell commands to use the new version and include the management URL option, and adjusted the condition when to start Netbird. |
| roles/netbird/defaults/main.yml | Introduced the netbird_mgmt_url variable with a default to the cloud-hosted instance. |
| roles/netbird/README.md | Added documentation for the new netbird_mgmt_url variable. |
spam-n-eggs
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netbird_mgmt_url.netbird_mgmt_url.