chore(deps): Update Node.js version and package dependencies #31990
Conversation
- Updated Node.js version in and to v20.19.1. - Adjusted package dependencies in , including updates to , , and various Babel packages for improved compatibility and performance. - Enhanced type imports in for better type safety and clarity in Angular component properties. - Refactored to streamline imports and improve code organization. These changes aim to ensure compatibility with the latest Node.js features and enhance overall project maintainability.
- Updated the Node.js version in and to v20.19.1 for improved compatibility and performance.
- Updated Node.js version in .nvmrc and core-web/.nvmrc to v22.15.0 for improved compatibility and performance. - Adjusted package.json to reflect the new Node.js version requirement.
oidacra
requested review from
fmontes,
nicobytes,
dcolina,
zJaaal,
rjvelazco and
KevinDavilaDotCMS
![semgrep-code-dotcms-test[bot]](https://avatars.githubusercontent.com/u/1005263?s=60&v=4){kind=small}
| xmlbuilder "15.1.1" | ||
|
|
||
| node-forge@1.3.1: |
There was a problem hiding this comment.
Legal Risk
node-forge 1.3.1 was released under the GPL-2.0 license, a license that
has been flagged by your organization for consideration.
Recommendation
While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.
| setHighlight: | ||
| () => | ||
| ({ commands }) => { | ||
| // Implementa la lógica de highlight aquí | ||
| return true; | ||
| }, | ||
| unsetHighlight: | ||
| () => | ||
| ({ commands }) => { | ||
| // Implementa la lógica para remover el highlight aquí | ||
| return true; | ||
| }, |
There was a problem hiding this comment.
Yes, without that, the component will not build.
| setHighlight: | ||
| () => | ||
| ({ commands }) => { | ||
| // Implementa la lógica de highlight aquí |
There was a problem hiding this comment.
Remove comment? Or translate them to en?
| <!-- Force to use node v18.20.3 --> | ||
| <node.js.version>v18.20.3</node.js.version> |
There was a problem hiding this comment.
Why are we forcing node v18 here?
| "main": "index.js", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "newman": "^6.2.1", |
There was a problem hiding this comment.
Do we need a BE checking that this doesn't break anything?
| @@ -131,7 +131,7 @@ test-integration-stop: | |||
| ./mvnw -pl :dotcms-integration -Pdocker-stop -Dcoreit.test.skip=false | |||
|
|
|||
| test-postman-ide: | |||
| ./mvnw -pl :dotcms-test-karate pre-integration-test -Dpostman.test.skip=false -Dtomcat.port=8080 | |||
| ./mvnw -pl :dotcms-test-postman pre-integration-test -Dpostman.test.skip=false -Dtomcat.port=8080 | |||
There was a problem hiding this comment.
Yes. Steve B asked me to fix that typo.
These changes aim to ensure compatibility with the latest Node.js features and enhance overall project maintainability.