Fix ESLint issues (#10199)

* Fix ESLint issues

* Avoid using eslint flag config in VSCode

Author: eddeee888

.eslintrc.cjs

@@ -56,6 +56,12 @@ module.exports = {
         project: ['./tsconfig.json'],
       },
     },
+    {
+      files: ['scripts/*.{ts,js}', 'prettier.config.cjs', 'jest.config.js', 'jest.project.js'],
+      rules: {
+        '@typescript-eslint/no-require-imports': 'off',
+      },
+    },
   ],
   ignorePatterns: [
     'dev-test',

.vscode/settings.json

@@ -2,6 +2,7 @@
   "yaml.schemas": {
     "./website/static/config.schema.json": "*codegen.*"
   },
+  "eslint.useFlatConfig": false,
   "editor.tabSize": 2,
   "editor.insertSpaces": true,
   "editor.rulers": [80],

packages/graphql-codegen-cli/src/cli.ts

@@ -31,7 +31,7 @@ export async function runCli(cmd: string): Promise<number> {
 export async function ensureGraphQlPackage() {
   try {
     await import('graphql');
-  } catch (e) {
+  } catch {
     throw new Error(
       `Unable to load "graphql" package. Please make sure to install "graphql" as a dependency! \n
        To install "graphql", run:

packages/graphql-codegen-cli/src/graphql-config.ts

@@ -57,7 +57,7 @@ function isGraphQLConfig(config: GraphQLConfig): config is GraphQLConfig {
 
   try {
     return config.getDefault().hasExtension('codegen');
-  } catch (e) {}
+  } catch {}
 
   try {
     for (const projectName in config.projects) {
@@ -69,7 +69,7 @@ function isGraphQLConfig(config: GraphQLConfig): config is GraphQLConfig {
         }
       }
     }
-  } catch (e) {}
+  } catch {}
 
   return false;
 }

packages/graphql-codegen-cli/src/utils/watcher.ts

@@ -119,7 +119,7 @@ export const createWatcher = (
             // In ESM require is not defined
             try {
               delete require.cache[path];
-            } catch (err) {}
+            } catch {}
 
             if (eventName === 'update' && config.configFilePath && path === config.configFilePath) {
               log(`${logSymbols.info} Config file has changed, reloading...`);

packages/graphql-codegen-cli/tests/__mocks__/some-fetch.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 const {
   promises: { readFile },
 } = require('fs');

packages/graphql-codegen-cli/tests/custom-loaders/custom-documents-loader.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 const { parse } = require('graphql');
 const { readFileSync } = require('fs');
 const { join } = require('path');

packages/graphql-codegen-cli/tests/custom-loaders/custom-schema-loader-with-context.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 const { buildSchema } = require('graphql');
 const { readFileSync } = require('fs');
 const { join } = require('path');

packages/graphql-codegen-cli/tests/custom-loaders/custom-schema-loader.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 const { buildSchema } = require('graphql');
 const { readFileSync } = require('fs');
 const { join } = require('path');

packages/graphql-codegen-cli/tests/init.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 import { resolve } from 'path';
 import bddStdin from 'bdd-stdin';
 import { bold } from '../src/init/helpers.js';

packages/plugins/other/schema-ast/tests/schema-ast.spec.ts

@@ -39,7 +39,7 @@ describe('Schema AST', () => {
 
       try {
         await validate(null, null, null, fileName, plugins);
-      } catch (e) {
+      } catch {
         expect(true).toBeFalsy();
       }
     });
@@ -54,7 +54,7 @@ describe('Schema AST', () => {
 
       try {
         await validate(null, null, null, fileName, plugins);
-      } catch (e) {
+      } catch {
         expect(true).toBeFalsy();
       }
     });
@@ -69,7 +69,7 @@ describe('Schema AST', () => {
 
       try {
         await validate(null, null, null, fileName, plugins);
-      } catch (e) {
+      } catch {
         expect(true).toBeFalsy();
       }
     });
@@ -84,7 +84,7 @@ describe('Schema AST', () => {
 
       try {
         await validate(null, null, null, fileName, plugins);
-      } catch (e) {
+      } catch {
         expect(true).toBeFalsy();
       }
     });

packages/plugins/other/visitor-plugin-common/src/types.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import { ASTNode, FragmentDefinitionNode, DirectiveNode } from 'graphql';
 import { ParsedMapper } from './mappers.js';
 

packages/plugins/other/visitor-plugin-common/src/variables-to-object.ts

@@ -26,7 +26,7 @@ export class OperationVariablesToObject {
     protected _enumPrefix = true,
     protected _enumSuffix = true,
     protected _enumValues: ParsedEnumValuesMap = {},
-    protected _applyCoercion: Boolean = false,
+    protected _applyCoercion: boolean = false,
     protected _directiveArgumentAndInputFieldMappings: ParsedDirectiveArgumentAndInputFieldMappings = {}
   ) {
     autoBind(this);
@@ -122,7 +122,7 @@ export class OperationVariablesToObject {
     return `${formattedFieldString}: ${formattedTypeString}`;
   }
 
-  public wrapAstTypeWithModifiers(_baseType: string, _typeNode: TypeNode, _applyCoercion?: Boolean): string {
+  public wrapAstTypeWithModifiers(_baseType: string, _typeNode: TypeNode, _applyCoercion?: boolean): string {
     throw new Error(`You must override "wrapAstTypeWithModifiers" of OperationVariablesToObject!`);
   }
 

packages/plugins/typescript/operations/tests/ts-documents.spec.ts

@@ -5,6 +5,7 @@ import { plugin as tsPlugin } from '../../typescript/src/index.js';
 import { plugin } from '../src/index.js';
 
 describe('TypeScript Operations Plugin', () => {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const gitHuntSchema = buildClientSchema(require('../../../../../dev-test/githunt/schema.json'));
 
   const schema = buildSchema(/* GraphQL */ `

packages/plugins/typescript/typescript/src/typescript-variables-to-object.ts

@@ -19,7 +19,7 @@ export class TypeScriptOperationVariablesToObject extends OperationVariablesToOb
     _enumPrefix = true,
     _enumSuffix = true,
     _enumValues: ParsedEnumValuesMap = {},
-    _applyCoercion: Boolean = false,
+    _applyCoercion: boolean = false,
     _directiveArgumentAndInputFieldMappings: ParsedDirectiveArgumentAndInputFieldMappings = {},
     private _maybeType = 'Maybe'
   ) {

packages/utils/graphql-codegen-testing/src/index.ts

@@ -65,7 +65,7 @@ function findProjectDir(dirname: string): string | never {
       }
 
       dirname = resolve(dirname, '..');
-    } catch (e) {
+    } catch {
       // ignore
     }
   }