-
Notifications
You must be signed in to change notification settings - Fork 25.2k
JsonPatch System.Text.Json - based .NET 10 Preview 4 update #35571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mkArtakMSFT, could use your review. Is there a different alias I should use that is recognized by github for internal review? The one you used to create the issue does not seem to work. |
@guardrex, just CC for awareness in case you want to review, but not required. |
My only concern was the pass on the .NET 10 What's New guidance when the community member opened an issue about the package reference ... https://github.com/dotnet/AspNetCore.Docs/pull/35610/files So far, nothing is broken here. 🤞🍀 |
I missed that occurred, thanks. Ther was no issue tied to it and I wasn't on the loop. I didn't see it in time on the PR list. Looking it over now... |
I point to the correct one here: However, that is with the installation instructions. I'll mention it at the very top too as we did before, but of course to the new package. |
Actually, I DID persist that issue. Fixing it now. Thanks @guardrex! Plus adding the mention at the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a first round of comments. Perhaps you can address these while I put together an updated example app.
Here's a sample project that illustrates the new JSON Patch support in both a controller-based and Minimal APIs app (actually it is one app with both controllers and minimal API endpoints). https://github.com/mikekistler/aspnet-json-patch/tree/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also want at least a brief description of JSON Patch support in the Minimal APIs section of the doc.
|
Yes ... I think it should replace the current sample in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a few comments and suggestions.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Set back to draft. Next: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is more we want to do to document JsonPatch, like adding something into the Minimal APIs section of the docs, but what's here seems complete and accurate for controllers (modulo the one comment I left on fixing the refs) and I don't think we should wait to merge this, so approving.
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Fixes #35237
Fixes #35435
Table of changes with summaries:
Internal previews