Skip to content

[Pre6] Better EP docs with new names #35577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex June 4, 2025 17:33
@pavelsavara pavelsavara marked this pull request as ready for review June 4, 2025 17:36
@pavelsavara
Copy link
Member Author

@guardrex I re-wrote the article and probably butchered the language and formatting rules. Please help me to put it to proper form, many thanks.

cc @danroth27

@guardrex guardrex self-assigned this Jun 4, 2025
@guardrex
Copy link
Collaborator

guardrex commented Jun 4, 2025

Sure thing ... I'll reach this on Thursday morning.

@pavelsavara
Copy link
Member Author

pavelsavara commented Jun 4, 2025

@radekdoulik this is based on your feedback. Please have a look if this makes more sense now.

@guardrex
Copy link
Collaborator

guardrex commented Jun 4, 2025

I had time today.

I applied minor updates to conform to our styles and conventions.

It's ready to go when you are. Go ahead and squash and merge when ready.

@pavelsavara
Copy link
Member Author

@guardrex these new names would land in Net10 preview 6. Do we need to worry about timing of this merge ?

@guardrex
Copy link
Collaborator

guardrex commented Jun 5, 2025

Yes, we can only merge Preview 5 updates on June 10. Preview 6 updates merge on July 8.

Therefore, we either should leave this PR here until July 8 or modify it to display P5 names. If modifying it is best to get the content out next week, I recommend marking the P6 name changes directly in the markdown of the article using HTML comments ...

<!-- UPDATE 10.0 Preview 6 - Change XXXX to YYYY -->

FYI: I use "UPDATE 10.0 Preview X" or "UPDATE 10.0" (for GA) as keywords in HTML comments to track small changes, such as API name changes. This allows me to avoid having a long list of notes or many opened issues, and it makes it easy to find the exact spots that require attention. Please feel free to place HTML comments as needed. However, a new issue does make sense if the changes are more complicated.

@dotnet-policy-service dotnet-policy-service bot requested a review from guardrex June 5, 2025 13:02
@guardrex guardrex changed the title [wasm] better EP docs with new names [Pre6] Better EP docs with new names Jun 10, 2025
@guardrex
Copy link
Collaborator

guardrex commented Jun 12, 2025

@tdykstra ... U must have closed this by mistake. The "fixes" must be incorrect on your PR.

@guardrex guardrex reopened this Jun 12, 2025
@tdykstra
Copy link
Contributor

@tdykstra ... U must have closed this by mistake. The "fixes" must be incorrect on your PR.

Yes you are right I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants