-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Pre6] Better EP docs with new names #35577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@guardrex I re-wrote the article and probably butchered the language and formatting rules. Please help me to put it to proper form, many thanks. cc @danroth27 |
Sure thing ... I'll reach this on Thursday morning. |
@radekdoulik this is based on your feedback. Please have a look if this makes more sense now. |
I had time today. I applied minor updates to conform to our styles and conventions. It's ready to go when you are. Go ahead and squash and merge when ready. |
@guardrex these new names would land in Net10 preview 6. Do we need to worry about timing of this merge ? |
Yes, we can only merge Preview 5 updates on June 10. Preview 6 updates merge on July 8. Therefore, we either should leave this PR here until July 8 or modify it to display P5 names. If modifying it is best to get the content out next week, I recommend marking the P6 name changes directly in the markdown of the article using HTML comments ... <!-- UPDATE 10.0 Preview 6 - Change XXXX to YYYY --> FYI: I use "UPDATE 10.0 Preview X" or "UPDATE 10.0" (for GA) as keywords in HTML comments to track small changes, such as API name changes. This allows me to avoid having a long list of notes or many opened issues, and it makes it easy to find the exact spots that require attention. Please feel free to place HTML comments as needed. However, a new issue does make sense if the changes are more complicated. |
@tdykstra ... U must have closed this by mistake. The "fixes" must be incorrect on your PR. |
Yes you are right I will fix it. |
Related
Internal previews