Skip to content

Version the Let's Encrypt article #35615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jun 11, 2025

Fixes #35611

Thanks @danielwertheim! 🚀

Here's the article ...

https://learn.microsoft.com/en-us/aspnet/core/fundamentals/servers/yarp/lets-encrypt?view=aspnetcore-9.0

@natemcmaster, Dan ... Archived mid-.NET 9, so I marked the article for up to 8.0. Is that what you'd like to do here?


Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/servers/yarp/lets-encrypt.md aspnetcore/fundamentals/servers/yarp/lets-encrypt

@guardrex guardrex self-assigned this Jun 11, 2025
@guardrex guardrex requested a review from danroth27 June 11, 2025 16:46
@danielwertheim
Copy link

Don’t really think official Microsoft docs should link to unmaintained solutions at all, especially when it comes to security related features. If kept for history. It should clearly state that it’s not recommended anymore.

If I could wish whatever I want, then the team behind YARP would make an official and supported solution for this.

@guardrex
Copy link
Collaborator Author

guardrex commented Jun 11, 2025

It's ultimately up to Dan. He calls the shots on what external tech to support in the docs.

It should clearly state that it’s not recommended anymore.

It would only appear in the 8.0 or earlier doc set. When loaded, a message tells readers that the ASP.NET Core framework is no longer supported after the framework loses support. However, Dan may ask me to add a special note to the top of the article telling readers that the package is no longer supported. That's an easy update for the PR.

@danroth27
Copy link
Member

I think we don't want this article to be part of our docs for supported .NET versions (.NET 8 and later).

For older .NET versions, I like the idea of adding a note to state that the LettuceEncrypt package is archived and no longer supported, so it is no longer recommended.

@guardrex
Copy link
Collaborator Author

guardrex commented Jun 13, 2025

Cool ... I'll take care of this by EOD.

It will be versioned <=7.0, and I'll add a NOTE under the H1.

@guardrex guardrex merged commit 8deb1d7 into main Jun 13, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/version-lets-encrypt-article branch June 13, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated package referenced
3 participants