Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes attribute usage by removing redundant Attribute suffixes across several SqlClient types, and includes a few whitespace-only cleanups in comments/preprocessor blocks.
Changes:
- Replaced usages like
EditorBrowsableAttribute,ResCategoryAttribute,ResDescriptionAttribute,ConditionalAttribute, and fully-qualified serialization attributes with their shortened forms. - Cleaned up trailing whitespace and spacing around
#endifand comment lines.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameterCollection.cs | Shortened EditorBrowsableAttribute usage; minor doc comment whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs | Shortened OptionalFieldAttribute / IgnoreDataMember usages (netfx-only) and removed stray whitespace. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs | Shortened HostProtectionAttribute, ResCategoryAttribute, ResDescriptionAttribute; whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataReader.cs | Shortened EditorBrowsableAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataAdapter.cs | Shortened ResCategoryAttribute / ResDescriptionAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs | Shortened ResCategoryAttribute / SettingsBindableAttribute usages; whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommandBuilder.cs | Shortened EditorBrowsableAttribute, ResCategoryAttribute, ResDescriptionAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionString.netfx.cs | Shortened ConditionalAttribute usage and whitespace cleanup around #endif. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4158 +/- ##
==========================================
- Coverage 74.27% 65.46% -8.81%
==========================================
Files 279 274 -5
Lines 42980 66416 +23436
==========================================
+ Hits 31922 43482 +11560
- Misses 11058 22934 +11876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.