Skip to content

remove redundant Attribute( suffixes#4158

Open
SimonCropp wants to merge 1 commit intodotnet:mainfrom
SimonCropp:remove-redundant-Attribute(-suffixes
Open

remove redundant Attribute( suffixes#4158
SimonCropp wants to merge 1 commit intodotnet:mainfrom
SimonCropp:remove-redundant-Attribute(-suffixes

Conversation

@SimonCropp
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 03:55
@SimonCropp SimonCropp requested a review from a team as a code owner April 8, 2026 03:55
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes attribute usage by removing redundant Attribute suffixes across several SqlClient types, and includes a few whitespace-only cleanups in comments/preprocessor blocks.

Changes:

  • Replaced usages like EditorBrowsableAttribute, ResCategoryAttribute, ResDescriptionAttribute, ConditionalAttribute, and fully-qualified serialization attributes with their shortened forms.
  • Cleaned up trailing whitespace and spacing around #endif and comment lines.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameterCollection.cs Shortened EditorBrowsableAttribute usage; minor doc comment whitespace cleanup.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs Shortened OptionalFieldAttribute / IgnoreDataMember usages (netfx-only) and removed stray whitespace.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs Shortened HostProtectionAttribute, ResCategoryAttribute, ResDescriptionAttribute; whitespace cleanup.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataReader.cs Shortened EditorBrowsableAttribute usages.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataAdapter.cs Shortened ResCategoryAttribute / ResDescriptionAttribute usages.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs Shortened ResCategoryAttribute / SettingsBindableAttribute usages; whitespace cleanup.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommandBuilder.cs Shortened EditorBrowsableAttribute, ResCategoryAttribute, ResDescriptionAttribute usages.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionString.netfx.cs Shortened ConditionalAttribute usage and whitespace cleanup around #endif.

@paulmedynski paulmedynski self-assigned this Apr 10, 2026
@paulmedynski paulmedynski added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Apr 10, 2026
@paulmedynski paulmedynski added this to the 7.1.0-preview1 milestone Apr 10, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Apr 10, 2026
@paulmedynski
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.46%. Comparing base (52c7149) to head (96647df).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ient/src/Microsoft/Data/SqlClient/SqlConnection.cs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (52c7149) and HEAD (96647df). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (52c7149) HEAD (96647df)
CI-SqlClient 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
- Coverage   74.27%   65.46%   -8.81%     
==========================================
  Files         279      274       -5     
  Lines       42980    66416   +23436     
==========================================
+ Hits        31922    43482   +11560     
- Misses      11058    22934   +11876     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 65.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Health 💊 Issues/PRs that are targeted to source code quality improvements.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants