Embed dotnet-install scripts as resources in Aspire CLI (#12296)

* Initial plan

* Embed dotnet-install scripts as resources in Aspire CLI

- Add dotnet-install.sh and dotnet-install.ps1 as embedded resources
- Update DotNetSdkInstaller to extract scripts from embedded resources instead of downloading
- Remove HttpClient download logic
- Add test to verify embedded scripts are accessible

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>

* Add GitHub Action to auto-update dotnet-install scripts

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Update workflow to run daily instead of weekly

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Use C# 8 using declaration syntax for cleaner code

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

Author: 3 people

.github/workflows/update-dotnet-install-scripts.yml

@@ -0,0 +1,38 @@
+name: Update dotnet-install Scripts
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 6 * * *' # Daily at 06:00 UTC
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  update-scripts:
+    runs-on: ubuntu-latest
+    if: ${{ github.repository_owner == 'dotnet' }}
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Download dotnet-install.sh
+        run: |
+          curl -sSL -o src/Aspire.Cli/Resources/dotnet-install.sh https://dot.net/v1/dotnet-install.sh
+
+      - name: Download dotnet-install.ps1
+        run: |
+          curl -sSL -o src/Aspire.Cli/Resources/dotnet-install.ps1 https://dot.net/v1/dotnet-install.ps1
+
+      - name: Create or update pull request
+        uses: dotnet/actions-create-pull-request@e8d799aa1f8b17f324f9513832811b0a62f1e0b1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          branch: update-dotnet-install-scripts
+          base: main
+          commit-message: "[Automated] Update dotnet-install scripts"
+          labels: |
+            area-cli
+            area-engineering-systems
+          title: "[Automated] Update dotnet-install scripts"
+          body: "Auto-generated update of embedded dotnet-install.sh and dotnet-install.ps1 scripts from https://dot.net/v1/."

src/Aspire.Cli/Aspire.Cli.csproj

@@ -119,6 +119,11 @@
     </Compile>
   </ItemGroup>
 
+  <ItemGroup>
+    <EmbeddedResource Include="Resources\dotnet-install.sh" />
+    <EmbeddedResource Include="Resources\dotnet-install.ps1" />
+  </ItemGroup>
+
   <ItemGroup>
     <EmbeddedResource Update="Resources\ExecCommandStrings.resx">
       <Generator>ResXFileCodeGenerator</Generator>

src/Aspire.Cli/DotNet/DotNetSdkInstaller.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics;
+using System.Reflection;
 using System.Runtime.InteropServices;
 using Aspire.Cli.Configuration;
 using Microsoft.Extensions.Configuration;
@@ -143,17 +144,20 @@ public async Task InstallAsync(CancellationToken cancellationToken = default)
         Directory.CreateDirectory(sdksDirectory);
 
         // Determine which install script to use based on the platform
-        var (scriptUrl, scriptFileName, scriptRunner) = GetInstallScriptInfo();
+        var (resourceName, scriptFileName, scriptRunner) = GetInstallScriptInfo();
 
-        // Download the install script
+        // Extract the install script from embedded resources
         var scriptPath = Path.Combine(sdksDirectory, scriptFileName);
-        using (var httpClient = new HttpClient())
+        var assembly = Assembly.GetExecutingAssembly();
+        using var resourceStream = assembly.GetManifestResourceStream(resourceName);
+        if (resourceStream == null)
         {
-            httpClient.Timeout = TimeSpan.FromMinutes(5);
-            var scriptContent = await httpClient.GetStringAsync(scriptUrl, cancellationToken);
-            await File.WriteAllTextAsync(scriptPath, scriptContent, cancellationToken);
+            throw new InvalidOperationException($"Could not find embedded resource: {resourceName}");
         }
 
+        using var fileStream = File.Create(scriptPath);
+        await resourceStream.CopyToAsync(fileStream, cancellationToken);
+
         // Make the script executable on Unix-like systems
         if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
         {
@@ -298,23 +302,23 @@ private string GetSdksDirectory()
     /// <summary>
     /// Gets the install script information based on the current platform.
     /// </summary>
-    /// <returns>A tuple containing the script URL, script file name, and script runner command.</returns>
-    private static (string ScriptUrl, string ScriptFileName, string ScriptRunner) GetInstallScriptInfo()
+    /// <returns>A tuple containing the embedded resource name, script file name, and script runner command.</returns>
+    private static (string ResourceName, string ScriptFileName, string ScriptRunner) GetInstallScriptInfo()
     {
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
         {
             // Try pwsh first (PowerShell Core), then fall back to powershell (Windows PowerShell)
             var powerShellExecutable = GetAvailablePowerShell();
             return (
-                "https://dot.net/v1/dotnet-install.ps1",
+                "Aspire.Cli.Resources.dotnet-install.ps1",
                 "dotnet-install.ps1",
                 powerShellExecutable
             );
         }
         else
         {
             return (
-                "https://dot.net/v1/dotnet-install.sh",
+                "Aspire.Cli.Resources.dotnet-install.sh",
                 "dotnet-install.sh",
                 "bash"
             );