OpenAPI: [Required] public required string ShouldHaveMinLength { get; init; } is marked as required but doens't have a minlength

[niemyjski]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

[Required] public required string ShouldHaveMinLength { get; init; } is marked as required but doens't have a minlength. See SampleModel.ShouldNotHaveRegexPattern

Expected Behavior

These should just work out of the box.

Steps To Reproduce

Clone https://github.com/exceptionless/aspnet-core-net10-issues# and run it, hit the open api json endpoint.

Exceptions (if any)

No response

.NET Version

10 preview 6

Anything else?

MacOS Latest, Rider/VS Code

#62150

[captainsafia]

This is intentional at the moment. It's not clear that the minLength convention for required strings might apply here.

@mikekistler Thoughts on this? Should we be emitting minLength for required strings? My intuition says no since an empty string is technically a valid value.

[mikekistler]

@captainsafia I agree that an empty string is still a string, so it has a value.

If an empty string is not acceptable input to the application, it can simply add a [MinLength(1)] attribute on the property or parameter and get the desired setting. And if a developer wants to apply this semantic to all required string values this should be straightforward to do with a schema transformer.

[dotnet-policy-service]

This issue has been resolved and has not had any activity for 1 day. It will be closed for housekeeping purposes.

See our Issue Management Policies for more information.

[niemyjski]

Min length could be 0 or could be marked as required.