Add loopback addresses to the development certificate #64431
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Copilot finished reviewing on behalf of
danegsta
November 19, 2025 01:37
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ASP.NET Core development certificate by adding IPv4 (127.0.0.1) and IPv6 (::1) loopback IP addresses to the certificate's Subject Alternative Names (SAN). This enables the certificate to work with client restrictions that require accessing services by IP address instead of hostname, such as SQL Server or Azurite containers.
Key changes:
- Added loopback IP addresses (127.0.0.1 and ::1) to the development certificate SAN
- Incremented certificate version from 5 to 6 to reflect the format change
- Added
System.Netnamespace import forIPAddressclass usage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/Shared.sln | Solution file included in PR (no actual changes) |
| src/Shared/CertificateGeneration/CertificateManager.cs | Adds IPv4/IPv6 loopback addresses to certificate SANs, increments certificate version to 6, and adds System.Net import |
davidfowl
reviewed
Nov 19, 2025
DamianEdwards
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IPv4 and IPv6 Loopback Addresses to the development certificate
Adds 127.0.0.1 and ::1 to the development certificate SAN
Description
Adds the IPv4 (
127.0.01) and IPv6 (::1) loopback addresses to the development certificate Subject Alternative Names for the dev cert. This will allow the certificate to be used to secure services such as a SQL Server or Azurite container where there are client restrictions that require accessing the service by IP address instead of hostname.Fixes #64430